hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-15055) Major compaction is not triggered when both of TTL and hbase.hstore.compaction.max.size are set
Date Tue, 12 Jan 2016 21:30:39 GMT

    [ https://issues.apache.org/jira/browse/HBASE-15055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15094990#comment-15094990
] 

Ted Yu commented on HBASE-15055:
--------------------------------

Some minor comments:
{code}
+    boolean isPeriodicMC = isPeriodicMC(candidateSelection);
{code}
Please use MajorCompaction instead of MC so that the meaning of the method name is clearer.
{code}
+    if (lowTimestamp > 0l && lowTimestamp < (now - mcTime)) {
+      LOG.debug("Major compaction period has elapsed. Need to run a major compaction");
{code}
Please log major compaction period to make the message more informative.


> Major compaction is not triggered when both of TTL and hbase.hstore.compaction.max.size
are set
> -----------------------------------------------------------------------------------------------
>
>                 Key: HBASE-15055
>                 URL: https://issues.apache.org/jira/browse/HBASE-15055
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Eungsop Yoo
>            Assignee: Eungsop Yoo
>            Priority: Minor
>         Attachments: HBASE-15055-v1.patch, HBASE-15055-v10.patch, HBASE-15055-v2.patch,
HBASE-15055-v3.patch, HBASE-15055-v4.patch, HBASE-15055-v5.patch, HBASE-15055-v6.patch, HBASE-15055-v7.patch,
HBASE-15055-v8.patch, HBASE-15055-v9.patch, HBASE-15055.patch
>
>
> Some large files may be skipped by hbase.hstore.compaction.max.size in candidate selection.
It causes skipping of major compaction. So the TTL expired records are still remained in the
disks and keep consuming disks.
> To resolve this issue, I suggest that to skip large files only if there is no TTL expired
record.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message