hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-15052) Use EnvironmentEdgeManager in ReplicationSource
Date Tue, 12 Jan 2016 00:18:39 GMT

    [ https://issues.apache.org/jira/browse/HBASE-15052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15092975#comment-15092975
] 

Hudson commented on HBASE-15052:
--------------------------------

FAILURE: Integrated in HBase-1.1-JDK7 #1637 (See [https://builds.apache.org/job/HBase-1.1-JDK7/1637/])
HBASE-15052 Use EnvironmentEdgeManager in ReplicationSource (matteo.bertozzi: rev 893dff8bd39a6dbc7242fe10ed9328e46d3d5a71)
* hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java


> Use EnvironmentEdgeManager in ReplicationSource 
> ------------------------------------------------
>
>                 Key: HBASE-15052
>                 URL: https://issues.apache.org/jira/browse/HBASE-15052
>             Project: HBase
>          Issue Type: Bug
>          Components: Replication
>    Affects Versions: 2.0.0, 1.2.0, 1.1.2, 1.0.3, 0.98.16.1
>            Reporter: Matteo Bertozzi
>            Assignee: Matteo Bertozzi
>            Priority: Trivial
>             Fix For: 2.0.0, 1.2.1, 1.1.3, 0.98.17, 1.0.4
>
>         Attachments: HBASE-15052-v0.patch, HBASE-15052-v00.patch
>
>
> ReplicationSource is passing System.currentTimeMillis() to MetricsSource.setAgeOfLastShippedOp()
which is subtracting that from EnvironmentEdgeManager.currentTime().
> {code}
> // if there was nothing to ship and it's not an error
> // set "ageOfLastShippedOp" to <now> to indicate that we're current
> metrics.setAgeOfLastShippedOp(System.currentTimeMillis(), walGroupId);
> public void setAgeOfLastShippedOp(long timestamp, String walGroup) {
>     long age = EnvironmentEdgeManager.currentTime() - timestamp;
> {code}
>  we should just use EnvironmentEdgeManager.currentTime() in ReplicationSource



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message