hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-15016) StoreServices facility in Region
Date Wed, 06 Jan 2016 17:33:39 GMT

    [ https://issues.apache.org/jira/browse/HBASE-15016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15085889#comment-15085889

stack commented on HBASE-15016:

bq. One feedback we got when working on HBASE-13408 was that decisions 1 and 2 should be encapsulated
and managed within the memstore.

Yeah. This is how it should be if possible.

bq. What you are suggesting now is to add a ‘warning’ message sent by region to stores
that would trigger an in-memory flush and/or a compaction.

I'm wondering if you need signaling that the LB/low-water mark has been triggered vs UB/high-level
mark has been reached. Maybe you have enough info inside int he Store to figure it yourself
on what type of flush it is but no harm on there being richer request.

So, indeed, flushRequest is overloaded here. It just seems odd to me that the Region is aware
of notions of LB/UB and then internally the Store takes different actions dependent on whether
LB/UB but the Region is not passing on what it knows.

Thanks for the further explication. Helps.

> StoreServices facility in Region
> --------------------------------
>                 Key: HBASE-15016
>                 URL: https://issues.apache.org/jira/browse/HBASE-15016
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Eshcar Hillel
>            Assignee: Eshcar Hillel
>         Attachments: HBASE-15016-V01.patch, HBASE-15016-V02.patch, HBASE-15016-V03.patch,
> The default implementation of a memstore ensures that between two flushes the memstore
size increases monotonically. Supporting new memstores that store data in different formats
(specifically, compressed), or that allows to eliminate data redundancies in memory (e.g.,
via compaction), means that the size of the data stored in memory can decrease even between
two flushes. This requires memstores to have access to facilities that manipulate region counters
and synchronization.
> This subtasks introduces a new region interface -- StoreServices, through which store
components can access these facilities.

This message was sent by Atlassian JIRA

View raw message