hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-15016) StoreServices facility in Region
Date Wed, 06 Jan 2016 06:38:39 GMT

    [ https://issues.apache.org/jira/browse/HBASE-15016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15085057#comment-15085057
] 

stack commented on HBASE-15016:
-------------------------------

Pardon me [~eshcar] Had to start over. I went over the top. Had to start over. I went back
to your design doc and I think nomenclature and a little refactoring so this patch fits other
hbase patterns is all that is needed to get this in. Am working on this now.

So, in below:

{code}
3906	    if(memstoreActiveSize > memstoreLowerThreshold ||
3907	        memstoreTotalSize > memstoreUpperThreshold) {
3908	      requestFlush();
3909	    }
{code}

... flushRequest is overloaded? Sometimes we want to flush a memstore to a segment -- i.e.
a flush to memory -- and then other times, we need to clean out the pipeline and flush to
disk? Don't you want to distingush these two flush types? The requestFlush can be triggered
a bunch of times especially if it takes time for it to be acted upon.

> StoreServices facility in Region
> --------------------------------
>
>                 Key: HBASE-15016
>                 URL: https://issues.apache.org/jira/browse/HBASE-15016
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Eshcar Hillel
>            Assignee: Eshcar Hillel
>         Attachments: HBASE-15016-V01.patch, HBASE-15016-V02.patch, HBASE-15016-V03.patch,
Regioncounters.pdf
>
>
> The default implementation of a memstore ensures that between two flushes the memstore
size increases monotonically. Supporting new memstores that store data in different formats
(specifically, compressed), or that allows to eliminate data redundancies in memory (e.g.,
via compaction), means that the size of the data stored in memory can decrease even between
two flushes. This requires memstores to have access to facilities that manipulate region counters
and synchronization.
> This subtasks introduces a new region interface -- StoreServices, through which store
components can access these facilities.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message