hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-14902) Revert some of the stringency recently introduced by checkstyle tightening
Date Wed, 06 Jan 2016 03:38:40 GMT

    [ https://issues.apache.org/jira/browse/HBASE-14902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15084932#comment-15084932
] 

Hudson commented on HBASE-14902:
--------------------------------

FAILURE: Integrated in HBase-Trunk_matrix #612 (See [https://builds.apache.org/job/HBase-Trunk_matrix/612/])
HBASE-14902 Revert some of the stringency recently introduced by (stack: rev 72d32cc96b6cda7d7dc17cf3dc88235b01534d43)
* hbase-checkstyle/src/main/resources/hbase/checkstyle.xml


> Revert some of the stringency recently introduced by checkstyle tightening
> --------------------------------------------------------------------------
>
>                 Key: HBASE-14902
>                 URL: https://issues.apache.org/jira/browse/HBASE-14902
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: stack
>            Assignee: stack
>             Fix For: 2.0.0
>
>         Attachments: 14902.part1.patch, 14902.patch, 14902.patch
>
>
> I think we should undo some of the plugins that were recently added to checkstyle. They
are too much.
> JavadocTagContinuationIndentationCheck is about adding indent if javadoc is two lines
or more (javadoc tool doesn't care)
> NonEmptyAtclauseDescriptionCheck would have us add javadoc on each exception: e.g. @throws
IOException needs to have text added.
> NeedBracesCheck has us undoing cases where an if fits all on one line (don't want to
start style wars but if short and fits on one line, I think its more readable... but I could
relent on this one.... ).
> The first two at least should go.
> You ok w/ that [~appy]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message