hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HBASE-14902) Revert some of the stringency recently introduced by checkstyle tightening
Date Mon, 04 Jan 2016 22:23:39 GMT

     [ https://issues.apache.org/jira/browse/HBASE-14902?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

stack updated HBASE-14902:
      Resolution: Fixed
    Hadoop Flags: Reviewed
    Release Note: Changes the checkstyle so that on a continuation line for javadoc, instead
of default four spaces, instead not it is two spaces. Also one line statements as in if (true)
x =1; now pass checkstyle.
          Status: Resolved  (was: Patch Available)

Pushed to master. Thanks for review [~appy]

> Revert some of the stringency recently introduced by checkstyle tightening
> --------------------------------------------------------------------------
>                 Key: HBASE-14902
>                 URL: https://issues.apache.org/jira/browse/HBASE-14902
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: stack
>            Assignee: stack
>             Fix For: 2.0.0
>         Attachments: 14902.patch, 14902.patch
> I think we should undo some of the plugins that were recently added to checkstyle. They
are too much.
> JavadocTagContinuationIndentationCheck is about adding indent if javadoc is two lines
or more (javadoc tool doesn't care)
> NonEmptyAtclauseDescriptionCheck would have us add javadoc on each exception: e.g. @throws
IOException needs to have text added.
> NeedBracesCheck has us undoing cases where an if fits all on one line (don't want to
start style wars but if short and fits on one line, I think its more readable... but I could
relent on this one.... ).
> The first two at least should go.
> You ok w/ that [~appy]

This message was sent by Atlassian JIRA

View raw message