hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anoop Sam John (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-14841) Allow Dictionary to work with BytebufferedCells
Date Mon, 25 Jan 2016 06:44:39 GMT

    [ https://issues.apache.org/jira/browse/HBASE-14841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15114832#comment-15114832
] 

Anoop Sam John commented on HBASE-14841:
----------------------------------------

{code}
public void compressTags(OutputStream out, ByteBuffer in, int offset, int length)
105	      throws IOException {
106	    if (in.hasArray()) {
107	      compressTags(out, in.array(), offset + in.position(), length);
108	      ByteBufferUtils.skip(in, length);
109	    } else {
{code}
Why do we need to advance the pos in the BB?  Any way in else part we are not doing that.
 

ByteArrayBackedNode #setContents(ByteBuffer container, int offset, int length)
This needs a copy. Any way no one calls this and it is not expected.  So better can throw
Exception here.
Same way as in another class with setContent(byte[])

why equals not checking instance of other type? May be in actual flow it is coming out to
be this way.  But better handle fully. Else code looks to have bug. Pls handle.

> Allow Dictionary to work with BytebufferedCells
> -----------------------------------------------
>
>                 Key: HBASE-14841
>                 URL: https://issues.apache.org/jira/browse/HBASE-14841
>             Project: HBase
>          Issue Type: Sub-task
>          Components: regionserver, Scanners
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>         Attachments: HBASE-14841.patch, HBASE-14841_1.patch, HBASE-14841_2.patch, HBASE-14841_3.patch,
HBASE-14841_4.patch
>
>
> This is part of HBASE-14832 where we need to ensure that while BBCells are getting compacted
the TagCompression part should be working with BBCells.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message