hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13525) Update test-patch to leverage Apache Yetus
Date Fri, 08 Jan 2016 04:19:39 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15088675#comment-15088675
] 

Hadoop QA commented on HBASE-13525:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12781102/HBASE-13525.1.patch
  against master branch at commit f3ee6df0f2d0955c2b334a9131eb3994c00af0c4.
  ATTACHMENT ID: 12781102

    {color:red}-1 @author{color}.  The patch appears to contain 6 @author tags which the Hadoop
community has agreed to not allow in code contributions.

    {color:green}+1 tests included{color}.  The patch appears to include 12 new or modified
tests.

    {color:red}-1 Anti-pattern{color}.  The patch appears to have anti-pattern where BYTES_COMPARATOR
was omitted: +  warnings=$(${GREP} 'new TreeMap<byte.*()' "${patchfile}")
-  warnings=`$GREP 'new TreeMap<byte.*()' $PATCH_DIR/patch`.

    {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions
(2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0 2.7.1)

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the total number of
protoc compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 checkstyle{color}. The applied patch does not generate new checkstyle
errors.

    {color:red}-1 InterfaceAudience{color}.  The patch appears to contain InterfaceAudience
from hadoop rather than hbase: +  warnings=$(${GREP} 'import org.apache.hadoop.classification'
"${patchfile}")
-  warnings=`$GREP 'import org.apache.hadoop.classification' $PATCH_DIR/patch`.

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than
100:
    +  add_vote_table +1 hadoopcheck "Patch does not cause any errors with Hadoop ${HBASE_HADOOP_VERSIONS}."
+# TODO if we need th protoc check, we probably need to check building all the modules that
rely on hbase-protocol
+    add_vote_table -1 hbaseanti "" "The patch appears to have anti-pattern where BYTES_COMPARATOR
was omitted: ${warnings}."
+    add_vote_table -1 hbaseanti "" "The patch appears use Hadoop classification instead of
HBase: ${warnings}."
+#      yetus_warn "Found some suspicious process(es). Waiting a bit to see if they're just
slow to stop."
+#          zombie_process=$(jstack "${pid}" | "${GREP}" -e "\.Test" | "${GREP}" -e "\.java"|
head -3)

    {color:green}+1 site{color}.  The mvn post-site goal succeeds with this patch.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

    {color:green}+1 zombies{color}. No zombie tests found running at the end of the build.

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/17166//testReport/
Release Findbugs (version 2.0.3) 	warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/17166//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/17166//artifact/patchprocess/checkstyle-aggregate.html

  Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/17166//console

This message is automatically generated.

> Update test-patch to leverage Apache Yetus
> ------------------------------------------
>
>                 Key: HBASE-13525
>                 URL: https://issues.apache.org/jira/browse/HBASE-13525
>             Project: HBase
>          Issue Type: Improvement
>          Components: build
>            Reporter: Sean Busbey
>            Assignee: Sean Busbey
>              Labels: jenkins
>             Fix For: 2.0.0
>
>         Attachments: HBASE-13525.1.patch, HBASE-13525.2.patch
>
>
> Once HADOOP-11746 lands over in Hadoop, incorporate its changes into our test-patch.
Most likely easiest approach is to start with the Hadoop version and add in the features we
have locally that they don't.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message