Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 050EB102B6 for ; Mon, 28 Dec 2015 05:33:50 +0000 (UTC) Received: (qmail 36122 invoked by uid 500); 28 Dec 2015 05:33:49 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 36072 invoked by uid 500); 28 Dec 2015 05:33:49 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 36038 invoked by uid 99); 28 Dec 2015 05:33:49 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 28 Dec 2015 05:33:49 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 905002C14F9 for ; Mon, 28 Dec 2015 05:33:49 +0000 (UTC) Date: Mon, 28 Dec 2015 05:33:49 +0000 (UTC) From: "ramkrishna.s.vasudevan (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-15035) bulkloading hfiles with tags that require splits do not preserve tags MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-15035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15072439#comment-15072439 ] ramkrishna.s.vasudevan commented on HBASE-15035: ------------------------------------------------ i just saw this commit and also found why the suggestion of checking the includeTags from reader's context did not work In the patch v3 {code} this.includesTags = ctx.isCompressTags(); {code} Instead of checking ctx.isIncludeTags it is iscompressTags and hence includeTags on the new Writer would have been false. The reason why I was thinking not to hard code it to true always is because if we make it true always then the writer will append some empty tag info like 0 tag length and that will be removed only on compaction. > bulkloading hfiles with tags that require splits do not preserve tags > --------------------------------------------------------------------- > > Key: HBASE-15035 > URL: https://issues.apache.org/jira/browse/HBASE-15035 > Project: HBase > Issue Type: Bug > Components: HFile > Affects Versions: 0.98.0, 1.0.0, 2.0.0, 1.1.0, 1.2.0, 1.3.0 > Reporter: Jonathan Hsieh > Assignee: Jonathan Hsieh > Priority: Blocker > Fix For: 2.0.0, 1.2.0, 1.3.0, 1.1.3, 0.98.17, 1.0.4 > > Attachments: HBASE-15035-v2.patch, HBASE-15035-v3.patch, HBASE-15035-v4.patch, HBASE-15035.patch > > > When an hfile is created with cell tags present and it is bulk loaded into hbase the tags will be present when loaded into a single region. If the bulk load hfile spans multiple regions, bulk load automatically splits the original hfile into a set of split hfiles corresponding to each of the regions that the original covers. > Since 0.98, tags are not copied into the newly created split hfiles. (the default for "includeTags" of the HFileContextBuilder [1] is uninitialized which defaults to false). This means acls, ttls, mob pointers and other tag stored values will not be bulk loaded in. > [1] https://github.com/apache/hbase/blob/master/hbase-common/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileContextBuilder.java#L40 -- This message was sent by Atlassian JIRA (v6.3.4#6332)