Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 18EAF18659 for ; Tue, 22 Dec 2015 09:14:47 +0000 (UTC) Received: (qmail 37877 invoked by uid 500); 22 Dec 2015 09:14:46 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 37827 invoked by uid 500); 22 Dec 2015 09:14:46 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 37808 invoked by uid 99); 22 Dec 2015 09:14:46 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 22 Dec 2015 09:14:46 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id B368D2C14F6 for ; Tue, 22 Dec 2015 09:14:46 +0000 (UTC) Date: Tue, 22 Dec 2015 09:14:46 +0000 (UTC) From: "Yu Li (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HBASE-15028) Minor fix on RegionGroupingProvider MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-15028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yu Li updated HBASE-15028: -------------------------- Attachment: HBASE-15028.patch A straight forward patch > Minor fix on RegionGroupingProvider > ----------------------------------- > > Key: HBASE-15028 > URL: https://issues.apache.org/jira/browse/HBASE-15028 > Project: HBase > Issue Type: Bug > Components: wal > Affects Versions: 2.0.0, 1.3.0 > Reporter: Yu Li > Assignee: Yu Li > Priority: Minor > Fix For: 2.0.0, 1.3.0 > > Attachments: HBASE-15028.patch > > > Currently in {{RegionGroupingProvider#getWAL(String)}} we're trying to get a WAL instance from the cache using walCacheLock as the key (a typo when fixing HBASE-14306, my fault...), while actually we should have used group name. This won't cause any fatal error but will slightly affect the perf since it will always run into the succeeding synchronized code. Will get this fixed in this JIRA -- This message was sent by Atlassian JIRA (v6.3.4#6332)