Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3C01618D20 for ; Sat, 26 Dec 2015 04:57:50 +0000 (UTC) Received: (qmail 89121 invoked by uid 500); 26 Dec 2015 04:57:49 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 89060 invoked by uid 500); 26 Dec 2015 04:57:49 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 89044 invoked by uid 99); 26 Dec 2015 04:57:49 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 26 Dec 2015 04:57:49 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id A05BA2C1F55 for ; Sat, 26 Dec 2015 04:57:49 +0000 (UTC) Date: Sat, 26 Dec 2015 04:57:49 +0000 (UTC) From: "Tianyin Xu (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-15026) The default value of "hbase.regions.slop" in docs is obsolete MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-15026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15071815#comment-15071815 ] Tianyin Xu commented on HBASE-15026: ------------------------------------ [~yuzhihong@gmail.com], the changes of the default (from 0.2 to 0.001) breaks certain unit tests. It seems the {{0.2}} is assumed. If it's that case, we can still keep the 0.2 in hbase-default.xml but change the getter call in StochasticLoadBalancer.java. > The default value of "hbase.regions.slop" in docs is obsolete > ------------------------------------------------------------- > > Key: HBASE-15026 > URL: https://issues.apache.org/jira/browse/HBASE-15026 > Project: HBase > Issue Type: Bug > Components: Balancer > Affects Versions: 1.1.2 > Reporter: Tianyin Xu > Assignee: Tianyin Xu > Priority: Minor > Fix For: 2.0.0, 1.3.0 > > Attachments: HBASE.15026.patch > > > The default value of {{hbase.regions.slop}} is {{0.001}} in {{StochasticLoadBalancer}} (which is the default setting of {{hbase.master.loadbalancer.class}}). > However, in the docs (both {{hbase-default.xml}} and [online docs|http://hbase.apache.org/book.html#config.files]), the default value is {{0.2}}. This value is specified in {{BaseLoadBalancer}} (which is an abstract class) and is inherited by {{SimpleLoadBalancer}}. However, as {{SimpleLoadBalancer}} is no longer used as the default load balancer, the doc is obsolete. > The code structure is: > {code:title=BaseLoadBalancer.java|borderStyle=solid} > public abstract class BaseLoadBalancer implements LoadBalancer { > ... > protected void setSlop(Configuration conf) { > this.slop = conf.getFloat("hbase.regions.slop", (float) 0.2); > } > {code} > {code:title=StochasticLoadBalancer.java|borderStyle=solid} > public class StochasticLoadBalancer extends BaseLoadBalancer { > ... > @Override > protected void setSlop(Configuration conf) { > this.slop = conf.getFloat("hbase.regions.slop", 0.001F); > } > {code} > I suggest to make the manual entry of {{hbase.regions.slop}} specify the different default values in different balancer classes. -- This message was sent by Atlassian JIRA (v6.3.4#6332)