Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 63641189AD for ; Fri, 18 Dec 2015 01:05:47 +0000 (UTC) Received: (qmail 50978 invoked by uid 500); 18 Dec 2015 01:05:47 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 50911 invoked by uid 500); 18 Dec 2015 01:05:47 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 50636 invoked by uid 99); 18 Dec 2015 01:05:46 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 18 Dec 2015 01:05:46 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id C67BA2C1F78 for ; Fri, 18 Dec 2015 01:05:46 +0000 (UTC) Date: Fri, 18 Dec 2015 01:05:46 +0000 (UTC) From: "Hudson (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-14989) Implementation of Mutation.getWriteToWAL() is backwards MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-14989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15063208#comment-15063208 ] Hudson commented on HBASE-14989: -------------------------------- FAILURE: Integrated in HBase-1.3 #447 (See [https://builds.apache.org/job/HBase-1.3/447/]) HBASE-14989 Implementation of Mutation.getWriteToWAL() is backwards (enis: rev f3ebeeb3fced9cc1cc382e55d00e4fcb0b0390ab) * hbase-client/src/main/java/org/apache/hadoop/hbase/client/Mutation.java > Implementation of Mutation.getWriteToWAL() is backwards > ------------------------------------------------------- > > Key: HBASE-14989 > URL: https://issues.apache.org/jira/browse/HBASE-14989 > Project: HBase > Issue Type: Bug > Reporter: James Taylor > Assignee: Enis Soztutar > Fix For: 1.2.0, 1.3.0, 1.1.4, 0.98.17, 1.0.4 > > Attachments: HBASE-14989.1.branch-1.patch, hbase-14989-branch-1_v1.patch > > > The implementation of the deprecated getWriteToWAL is backwards. It should return true if this.durability == Durability.SYNC_WAL: > {code} > /** > * @deprecated Use {@link #getDurability()} instead. > * @return true if edits should be applied to WAL, false if not > */ > @Deprecated > public boolean getWriteToWAL() { > return this.durability == Durability.SKIP_WAL; > } > {code} > For example, if mutation.durability is Durability.SYNC_WAL and the following code is called {{clonedMutation.setWriteToWAL(mutation.getWriteToWAL())}}, it will disable writing to the WAL for clonedMutation. -- This message was sent by Atlassian JIRA (v6.3.4#6332)