Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Wed, 16 Dec 2015 22:14:46 +0000 (UTC)
From: "Enis Soztutar (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12922229.1450233317000.46407.1450304086731@Atlassian.JIRA>
In-Reply-To: <JIRA.12922229.1450233317000@Atlassian.JIRA>
References: <JIRA.12922229.1450233317000@Atlassian.JIRA>
 <JIRA.12922229.1450233317498@arcas>
Subject: [jira] [Updated] (HBASE-14989) Implementation of
 Mutation.getWriteToWAL() is backwards
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/HBASE-14989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Enis Soztutar updated HBASE-14989:
----------------------------------
    Attachment: hbase-14989-branch-1_v1.patch

Attaching v1. 

> Implementation of Mutation.getWriteToWAL() is backwards
> -------------------------------------------------------
>
>                 Key: HBASE-14989
>                 URL: https://issues.apache.org/jira/browse/HBASE-14989
>             Project: HBase
>          Issue Type: Bug
>            Reporter: James Taylor
>             Fix For: 1.3.0, 1.2.1, 1.1.4, 0.98.17, 1.0.4
>
>         Attachments: hbase-14989-branch-1_v1.patch
>
>
> The implementation of the deprecated getWriteToWAL is backwards. It should return true if this.durability == Durability.SYNC_WAL:
> {code}
> /**
>    * @deprecated Use {@link #getDurability()} instead.
>    * @return true if edits should be applied to WAL, false if not
>    */
>   @Deprecated
>   public boolean getWriteToWAL() {
>     return this.durability == Durability.SKIP_WAL;
>   }
> {code}
> For example, if mutation.durability is Durability.SYNC_WAL and the following code is called {{clonedMutation.setWriteToWAL(mutation.getWriteToWAL())}}, it will disable writing to the WAL for clonedMutation.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)