Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Wed, 16 Dec 2015 23:42:46 +0000 (UTC)
From: "Hadoop QA (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12922116.1450207846000.47478.1450309366683@Atlassian.JIRA>
In-Reply-To: <JIRA.12922116.1450207846000@Atlassian.JIRA>
References: <JIRA.12922116.1450207846000@Atlassian.JIRA>
 <JIRA.12922116.1450207846676@arcas>
Subject: [jira] [Commented] (HBASE-14983) Create metrics for per block type
 hit/miss ratios
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-14983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15061153#comment-15061153 ] 

Hadoop QA commented on HBASE-14983:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12778082/HBASE-14983-v2.patch
  against master branch at commit 7099ab4c56518024a26f5c499a9a1f2ea6bacd6e.
  ATTACHMENT ID: 12778082

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 11 new or modified tests.

    {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0 2.7.1)

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the total number of protoc compiler warnings.

    {color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 1 warning messages.

                {color:red}-1 checkstyle{color}.  The applied patch generated new checkstyle errors. Check build console for list of new errors.

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than 100:
    +  public BlockCacheKey(String hfileName, long offset, boolean isPrimaryReplica, BlockType blockType) {
+      return lruCacheStats.getIntermediateIndexMissCount() + bucketCacheStats.getIntermediateIndexMissCount();
+      return lruCacheStats.getGeneralBloomMetaMissCount() + bucketCacheStats.getGeneralBloomMetaMissCount();
+      return lruCacheStats.getDeleteFamilyBloomMissCount() + bucketCacheStats.getDeleteFamilyBloomMissCount();
+      return lruCacheStats.getIntermediateIndexHitCount() + bucketCacheStats.getIntermediateIndexHitCount();
+      return lruCacheStats.getGeneralBloomMetaHitCount() + bucketCacheStats.getGeneralBloomMetaHitCount();
+      return lruCacheStats.getDeleteFamilyBloomHitCount() + bucketCacheStats.getDeleteFamilyBloomHitCount();
+      if (!repeat && updateCacheMetrics) stats.miss(caching, cacheKey.isPrimary(), cacheKey.getBlockType());

    {color:green}+1 site{color}.  The mvn post-site goal succeeds with this patch.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

    {color:green}+1 zombies{color}. No zombie tests found running at the end of the build.

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/16884//testReport/
Release Findbugs (version 2.0.3) 	warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/16884//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/16884//artifact/patchprocess/checkstyle-aggregate.html

                Javadoc warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/16884//artifact/patchprocess/patchJavadocWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/16884//console

This message is automatically generated.

> Create metrics for per block type hit/miss ratios
> -------------------------------------------------
>
>                 Key: HBASE-14983
>                 URL: https://issues.apache.org/jira/browse/HBASE-14983
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Elliott Clark
>            Assignee: Elliott Clark
>         Attachments: HBASE-14983-v1.patch, HBASE-14983-v2.patch, HBASE-14983.patch, Screen Shot 2015-12-15 at 3.33.09 PM.png
>
>
> Missing a root index block is worse than missing a data block. We should know the difference


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)