Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 881F818B15 for ; Wed, 16 Dec 2015 17:54:48 +0000 (UTC) Received: (qmail 4239 invoked by uid 500); 16 Dec 2015 17:54:47 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 4065 invoked by uid 500); 16 Dec 2015 17:54:47 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 3632 invoked by uid 99); 16 Dec 2015 17:54:47 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 16 Dec 2015 17:54:47 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 0C8C72C1F88 for ; Wed, 16 Dec 2015 17:54:47 +0000 (UTC) Date: Wed, 16 Dec 2015 17:54:47 +0000 (UTC) From: "Matteo Bertozzi (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-14977) ChoreService.shutdown may result in ConcurrentModificationException MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-14977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15060404#comment-15060404 ] Matteo Bertozzi commented on HBASE-14977: ----------------------------------------- on a local run I get: {noformat} org.junit.runners.model.TestTimedOutException: test timed out after 20000 milliseconds at org.apache.hadoop.hbase.ScheduledChore.getName(ScheduledChore.java:272) at org.apache.hadoop.hbase.ScheduledChore.toString(ScheduledChore.java:344) at java.lang.String.valueOf(String.java:2847) at java.lang.StringBuilder.append(StringBuilder.java:128) at java.util.AbstractCollection.toString(AbstractCollection.java:458) at java.lang.String.valueOf(String.java:2847) at java.lang.StringBuilder.append(StringBuilder.java:128) at org.apache.hadoop.hbase.ChoreService.shutdown(ChoreService.java:323) at org.apache.hadoop.hbase.TestChoreService.shutdownService(TestChoreService.java:363) at org.apache.hadoop.hbase.TestChoreService.testShutdownRejectsNewSchedules(TestChoreService.java:844) {noformat} {noformat} Potentially hanging thread: testShutdownRejectsNewSchedules_ChoreService_1 org.apache.hadoop.hbase.ChoreService.isChoreScheduled(ChoreService.java:205) org.apache.hadoop.hbase.ScheduledChore.isScheduled(ScheduledChore.java:314) org.apache.hadoop.hbase.ScheduledChore.run(ScheduledChore.java:176) java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471) java.util.concurrent.FutureTask.runAndReset(FutureTask.java:304) java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:178) java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293) java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) java.lang.Thread.run(Thread.java:745) Potentially hanging thread: Time-limited test org.apache.hadoop.hbase.ScheduledChore.getName(ScheduledChore.java:272) org.apache.hadoop.hbase.ScheduledChore.toString(ScheduledChore.java:344) java.lang.String.valueOf(String.java:2847) java.lang.StringBuilder.append(StringBuilder.java:128) java.util.AbstractCollection.toString(AbstractCollection.java:458) java.lang.String.valueOf(String.java:2847) java.lang.StringBuilder.append(StringBuilder.java:128) org.apache.hadoop.hbase.ChoreService.shutdown(ChoreService.java:323) org.apache.hadoop.hbase.TestChoreService.shutdownService(TestChoreService.java:363) org.apache.hadoop.hbase.TestChoreService.testShutdownRejectsNewSchedules(TestChoreService.java:844) sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) java.lang.reflect.Method.invoke(Method.java:606) org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50) org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47) org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:298) org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:292) java.util.concurrent.FutureTask.run(FutureTask.java:262) java.lang.Thread.run(Thread.java:745) {noformat} > ChoreService.shutdown may result in ConcurrentModificationException > ------------------------------------------------------------------- > > Key: HBASE-14977 > URL: https://issues.apache.org/jira/browse/HBASE-14977 > Project: HBase > Issue Type: Bug > Reporter: Vladimir Rodionov > Assignee: Vladimir Rodionov > Priority: Minor > Fix For: 2.0.0, 1.2.0, 1.3.0, 1.1.4 > > Attachments: HBASE-14977-v1.patch > > > As seen in this test: > https://builds.apache.org/job/HBase-1.3/jdk=latest1.8,label=Hadoop/425/artifact/hbase-server/target/surefire-reports/org.apache.hadoop.hbase.regionserver.compactions.TestFIFOCompactionPolicy-output.txt > We need to make shutdown method synchronized to avoid this issue. -- This message was sent by Atlassian JIRA (v6.3.4#6332)