Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A6629188C1 for ; Wed, 16 Dec 2015 05:18:47 +0000 (UTC) Received: (qmail 68505 invoked by uid 500); 16 Dec 2015 05:18:47 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 68135 invoked by uid 500); 16 Dec 2015 05:18:47 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 68004 invoked by uid 99); 16 Dec 2015 05:18:46 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 16 Dec 2015 05:18:46 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id C69D32C1F72 for ; Wed, 16 Dec 2015 05:18:46 +0000 (UTC) Date: Wed, 16 Dec 2015 05:18:46 +0000 (UTC) From: "Hudson (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-14947) WALProcedureStore improvements MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-14947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15059506#comment-15059506 ] Hudson commented on HBASE-14947: -------------------------------- FAILURE: Integrated in HBase-1.3 #439 (See [https://builds.apache.org/job/HBase-1.3/439/]) HBASE-14947 WALProcedureStore improvements (matteo.bertozzi: rev bf7c36fccac5477d08e296ad93671d2c30ae2dc8) * hbase-procedure/src/test/java/org/apache/hadoop/hbase/procedure2/TestProcedureRecovery.java * hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/store/ProcedureStoreTracker.java * hbase-procedure/src/test/java/org/apache/hadoop/hbase/procedure2/store/wal/TestWALProcedureStore.java * hbase-procedure/src/test/java/org/apache/hadoop/hbase/procedure2/store/TestProcedureStoreTracker.java * hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/store/wal/WALProcedureStore.java > WALProcedureStore improvements > ------------------------------ > > Key: HBASE-14947 > URL: https://issues.apache.org/jira/browse/HBASE-14947 > Project: HBase > Issue Type: Sub-task > Components: proc-v2 > Reporter: Ashu Pachauri > Assignee: Matteo Bertozzi > Priority: Blocker > Fix For: 2.0.0, 1.2.0, 1.1.3 > > Attachments: HBASE-14947-v0.patch, HBASE-14947-v1.patch > > > We ended up with a deadlock in HBASE-14943, with the storeTracker and lock acquired in reverse order by syncLoop() and insert/update/delete. In the syncLoop() with don't need the lock when we try to roll or removeInactive. also we can move the insert/update/delete tracker check in the syncLoop avoiding to the extra lock operation. -- This message was sent by Atlassian JIRA (v6.3.4#6332)