Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Wed, 9 Dec 2015 08:17:11 +0000 (UTC)
From: "Hadoop QA (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12919915.1449538775000.310281.1449649031422@Atlassian.JIRA>
In-Reply-To: <JIRA.12919915.1449538775000@Atlassian.JIRA>
References: <JIRA.12919915.1449538775000@Atlassian.JIRA>
 <JIRA.12919915.1449538775235@arcas>
Subject: [jira] [Commented] (HBASE-14947) WALProcedureStore improvements
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-14947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15048267#comment-15048267 ] 

Hadoop QA commented on HBASE-14947:
-----------------------------------

{color:green}+1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12776484/HBASE-14947-v1.patch
  against master branch at commit 7bfbb6a3c9af4b0e2853b5ea2580a05bb471211b.
  ATTACHMENT ID: 12776484

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 9 new or modified tests.

    {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0 2.7.1)

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the total number of protoc compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 checkstyle{color}. The applied patch does not generate new checkstyle errors.

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

    {color:green}+1 site{color}.  The mvn post-site goal succeeds with this patch.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

    {color:green}+1 zombies{color}. No zombie tests found running at the end of the build.

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/16806//testReport/
Release Findbugs (version 2.0.3) 	warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/16806//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/16806//artifact/patchprocess/checkstyle-aggregate.html

  Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/16806//console

This message is automatically generated.

> WALProcedureStore improvements
> ------------------------------
>
>                 Key: HBASE-14947
>                 URL: https://issues.apache.org/jira/browse/HBASE-14947
>             Project: HBase
>          Issue Type: Sub-task
>          Components: proc-v2
>            Reporter: Ashu Pachauri
>            Assignee: Matteo Bertozzi
>            Priority: Minor
>         Attachments: HBASE-14947-v0.patch, HBASE-14947-v1.patch
>
>
> We ended up with a deadlock in HBASE-14943, with the storeTracker and lock acquired in reverse order by syncLoop() and insert/update/delete. In the syncLoop() with don't need the lock when we try to roll or removeInactive. also we can move the insert/update/delete tracker check in the syncLoop avoiding to the extra lock operation.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)