Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4794218822 for ; Mon, 14 Dec 2015 10:29:47 +0000 (UTC) Received: (qmail 69915 invoked by uid 500); 14 Dec 2015 10:29:47 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 69867 invoked by uid 500); 14 Dec 2015 10:29:47 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 69815 invoked by uid 99); 14 Dec 2015 10:29:47 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 14 Dec 2015 10:29:47 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id C70982C1F78 for ; Mon, 14 Dec 2015 10:29:46 +0000 (UTC) Date: Mon, 14 Dec 2015 10:29:46 +0000 (UTC) From: "Jianwei Cui (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HBASE-14936) CombinedBlockCache should overwrite CacheStats#rollMetricsPeriod() MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-14936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jianwei Cui updated HBASE-14936: -------------------------------- Attachment: HBASE-14936-branch-1.0-1.1.patch patch for branch-1.0 and branch-1.1 > CombinedBlockCache should overwrite CacheStats#rollMetricsPeriod() > ------------------------------------------------------------------ > > Key: HBASE-14936 > URL: https://issues.apache.org/jira/browse/HBASE-14936 > Project: HBase > Issue Type: Bug > Components: BlockCache > Affects Versions: 1.1.2 > Reporter: Jianwei Cui > Assignee: Jianwei Cui > Fix For: 2.0.0, 1.2, 1.1, 1.3 > > Attachments: HBASE-14936-branch-1.0-1.1.patch, HBASE-14936-trunk-v1.patch, HBASE-14936-trunk-v2.patch, HBASE-14936-trunk.patch > > > It seems CombinedBlockCache should overwrite CacheStats#rollMetricsPeriod() as > {code} > public void rollMetricsPeriod() { > lruCacheStats.rollMetricsPeriod(); > bucketCacheStats.rollMetricsPeriod(); > } > {code} > otherwise, CombinedBlockCache.getHitRatioPastNPeriods() and CombinedBlockCache.getHitCachingRatioPastNPeriods() will always return 0. -- This message was sent by Atlassian JIRA (v6.3.4#6332)