Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9E7FD18DBE for ; Thu, 3 Dec 2015 09:33:11 +0000 (UTC) Received: (qmail 31367 invoked by uid 500); 3 Dec 2015 09:33:11 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 31183 invoked by uid 500); 3 Dec 2015 09:33:11 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 31077 invoked by uid 99); 3 Dec 2015 09:33:11 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 03 Dec 2015 09:33:11 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 15BAB2C1F6B for ; Thu, 3 Dec 2015 09:33:11 +0000 (UTC) Date: Thu, 3 Dec 2015 09:33:11 +0000 (UTC) From: "Yu Li (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-14906) Improvements on FlushLargeStoresPolicy MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-14906?page=3Dcom.atlassia= n.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D150= 37561#comment-15037561 ]=20 Yu Li commented on HBASE-14906: ------------------------------- >From the HadoopQA report, observe below failures (errors) although it says = +1: {noformat} Tests in error:=20 org.apache.hadoop.hbase.regionserver.TestBulkLoad.bulkHLogShouldThrowErrorW= henFamilySpecifiedAndHFileExistsButNotInTableDescriptor(org.apache.hadoop.h= base.regionserver.TestBulkLoad) Run 1: TestBulkLoad.bulkHLogShouldThrowErrorWhenFamilySpecifiedAndHFileEx= istsButNotInTableDescriptor =C3=AF=C2=BF=C2=BD=20 Run 2: TestBulkLoad.bulkHLogShouldThrowErrorWhenFamilySpecifiedAndHFileEx= istsButNotInTableDescriptor =C3=AF=C2=BF=C2=BD=20 Run 3: TestBulkLoad.bulkHLogShouldThrowErrorWhenFamilySpecifiedAndHFileEx= istsButNotInTableDescriptor =C3=AF=C2=BF=C2=BD=20 org.apache.hadoop.hbase.regionserver.TestBulkLoad.shouldThrowErrorIfBadFami= lySpecifiedAsFamilyPath(org.apache.hadoop.hbase.regionserver.TestBulkLoad) Run 1: TestBulkLoad.shouldThrowErrorIfBadFamilySpecifiedAsFamilyPath =C3= =AF=C2=BF=C2=BD Unexpected ex... Run 2: TestBulkLoad.shouldThrowErrorIfBadFamilySpecifiedAsFamilyPath =C3= =AF=C2=BF=C2=BD Unexpected ex... Run 3: TestBulkLoad.shouldThrowErrorIfBadFamilySpecifiedAsFamilyPath =C3= =AF=C2=BF=C2=BD Unexpected ex... {noformat} And detailed exception: {noformat} shouldThrowErrorIfBadFamilySpecifiedAsFamilyPath(org.apache.hadoop.hbase.re= gionserver.TestBulkLoad) Time elapsed: 0.043 sec <<< ERROR! java.lang.Exception: Unexpected exception, expected but was =09at org.apache.hadoop.hbase.regionserver.FlushLargeStoresPolicy.configure= ForRegion(FlushLargeStoresPolicy.java:59) =09at org.apache.hadoop.hbase.regionserver.FlushPolicyFactory.create(FlushP= olicyFactory.java:52) =09at org.apache.hadoop.hbase.regionserver.HRegion.initializeRegionInternal= s(HRegion.java:845) =09at org.apache.hadoop.hbase.regionserver.HRegion.initialize(HRegion.java:= 786) =09at org.apache.hadoop.hbase.regionserver.HRegion.createHRegion(HRegion.ja= va:6195) =09at org.apache.hadoop.hbase.regionserver.HRegion.createHRegion(HRegion.ja= va:6204) =09at org.apache.hadoop.hbase.regionserver.TestBulkLoad.testRegionWithFamil= iesAndSpecifiedTableName(TestBulkLoad.java:239) =09at org.apache.hadoop.hbase.regionserver.TestBulkLoad.testRegionWithFamil= ies(TestBulkLoad.java:249) =09at org.apache.hadoop.hbase.regionserver.TestBulkLoad.shouldThrowErrorIfB= adFamilySpecifiedAsFamilyPath(TestBulkLoad.java:207) {noformat} Since these are Errors not Failures, the test stop at the middle phase. The issue is caused by the patch here since it doesn't handle the case that= column family number is zero, although this won't happen in real world, it= 's possible in our unit test case like TestBulkload. > Improvements on FlushLargeStoresPolicy > -------------------------------------- > > Key: HBASE-14906 > URL: https://issues.apache.org/jira/browse/HBASE-14906 > Project: HBase > Issue Type: Improvement > Affects Versions: 2.0.0 > Reporter: Yu Li > Assignee: Yu Li > Fix For: 2.0.0 > > Attachments: HBASE-14906.patch, HBASE-14906.v2.patch > > > When checking FlushLargeStoragePolicy, found below possible improving poi= nts: > 1. Currently in selectStoresToFlush, we will do the selection no matter h= ow many actual families, which is not necessary for one single family > 2. Default value for hbase.hregion.percolumnfamilyflush.size.lower.bound = could not fit in all cases, and requires user to know details of the implem= entation to properly set it. We propose to use "hbase.hregion.memstore.flus= h.size/column_family_number" instead: > {noformat} > > hbase.hregion.percolumnfamilyflush.size.lower.bound > 16777216 > > If FlushLargeStoresPolicy is used and there are multiple column famil= ies, > then every time that we hit the total memstore limit, we find out all= the > column families whose memstores exceed a "lower bound" and only flush= them > while retaining the others in memory. The "lower bound" will be > "hbase.hregion.memstore.flush.size / column_family_number" by default > unless value of this property is larger than that. If none of the fam= ilies > have their memstore size more than lower bound, all the memstores wil= l be > flushed (just as usual). > > > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)