Return-Path: 
 <issues-return-222512-apmail-hbase-issues-archive=hbase.apache.org@hbase.apache.org>
X-Original-To: apmail-hbase-issues-archive@www.apache.org
Delivered-To: apmail-hbase-issues-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 6E042180D9
	for <apmail-hbase-issues-archive@www.apache.org>;
 Wed,  2 Dec 2015 10:35:11 +0000 (UTC)
Received: (qmail 2655 invoked by uid 500); 2 Dec 2015 10:35:11 -0000
Delivered-To: apmail-hbase-issues-archive@hbase.apache.org
Received: (qmail 2552 invoked by uid 500); 2 Dec 2015 10:35:11 -0000
Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@hbase.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@hbase.apache.org>
List-Post: <mailto:issues@hbase.apache.org>
List-Id: <issues.hbase.apache.org>
Delivered-To: mailing list issues@hbase.apache.org
Received: (qmail 2479 invoked by uid 99); 2 Dec 2015 10:35:11 -0000
Received: from arcas.apache.org (HELO arcas) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 02 Dec 2015 10:35:11 +0000
Received: from arcas.apache.org (localhost [127.0.0.1])
	by arcas (Postfix) with ESMTP id 08C6A2C1F6C
	for <issues@hbase.apache.org>; Wed,  2 Dec 2015 10:35:11 +0000 (UTC)
Date: Wed, 2 Dec 2015 10:35:11 +0000 (UTC)
From: "Duo Zhang (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12917495.1449043056000.244037.1449052511032@Atlassian.JIRA>
In-Reply-To: <JIRA.12917495.1449043056000@Atlassian.JIRA>
References: <JIRA.12917495.1449043056000@Atlassian.JIRA>
 <JIRA.12917495.1449043056016@arcas>
Subject: [jira] [Commented] (HBASE-14906) Improvements on
 FlushLargeStoresPolicy
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/HBASE-14906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15035610#comment-15035610 ] 

Duo Zhang commented on HBASE-14906:
-----------------------------------

+1 on the idea.

Only one thing, I think we should still use {{region.getMemstoreFlushSize() / familyNumber}} even if we have a table config in the table description? In the patch you only compare the value with global config.

Thanks.


> Improvements on FlushLargeStoresPolicy
> --------------------------------------
>
>                 Key: HBASE-14906
>                 URL: https://issues.apache.org/jira/browse/HBASE-14906
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 2.0.0
>            Reporter: Yu Li
>            Assignee: Yu Li
>         Attachments: HBASE-14906.patch
>
>
> When checking FlushLargeStoragePolicy, found below possible improving points:
> 1. Currently in selectStoresToFlush, we will do the selection no matter how many actual families, which is not necessary for one single family
> 2. Default value for hbase.hregion.percolumnfamilyflush.size.lower.bound could not fit in all cases, and requires user to know details of the implementation to properly set it. We propose to use "hbase.hregion.memstore.flush.size/column_family_number" instead:
> {noformat}
>   <property>
>     <name>hbase.hregion.percolumnfamilyflush.size.lower.bound</name>
>     <value>16777216</value>
>     <description>
>     If FlushLargeStoresPolicy is used and there are multiple column families,
>     then every time that we hit the total memstore limit, we find out all the
>     column families whose memstores exceed a "lower bound" and only flush them
>     while retaining the others in memory. The "lower bound" will be
>     "hbase.hregion.memstore.flush.size / column_family_number" by default
>     unless value of this property is larger than that. If none of the families
>     have their memstore size more than lower bound, all the memstores will be
>     flushed (just as usual).
>     </description>
>   </property>
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)