Return-Path: 
 <issues-return-222790-apmail-hbase-issues-archive=hbase.apache.org@hbase.apache.org>
X-Original-To: apmail-hbase-issues-archive@www.apache.org
Delivered-To: apmail-hbase-issues-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 9C1C4101DD
	for <apmail-hbase-issues-archive@www.apache.org>;
 Fri,  4 Dec 2015 06:29:11 +0000 (UTC)
Received: (qmail 89051 invoked by uid 500); 4 Dec 2015 06:29:11 -0000
Delivered-To: apmail-hbase-issues-archive@hbase.apache.org
Received: (qmail 89000 invoked by uid 500); 4 Dec 2015 06:29:11 -0000
Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@hbase.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@hbase.apache.org>
List-Post: <mailto:issues@hbase.apache.org>
List-Id: <issues.hbase.apache.org>
Delivered-To: mailing list issues@hbase.apache.org
Received: (qmail 88943 invoked by uid 99); 4 Dec 2015 06:29:11 -0000
Received: from arcas.apache.org (HELO arcas) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 04 Dec 2015 06:29:11 +0000
Received: from arcas.apache.org (localhost [127.0.0.1])
	by arcas (Postfix) with ESMTP id 0E77A2C1F73
	for <issues@hbase.apache.org>; Fri,  4 Dec 2015 06:29:11 +0000 (UTC)
Date: Fri, 4 Dec 2015 06:29:11 +0000 (UTC)
From: "Hudson (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12917460.1449027424000.269163.1449210551056@Atlassian.JIRA>
In-Reply-To: <JIRA.12917460.1449027424000@Atlassian.JIRA>
References: <JIRA.12917460.1449027424000@Atlassian.JIRA>
 <JIRA.12917460.1449027424040@arcas>
Subject: [jira] [Commented] (HBASE-14904) Mark Base[En|De]coder
 LimitedPrivate and fix binary compat issue
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/HBASE-14904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15040796#comment-15040796 ] 

Hudson commented on HBASE-14904:
--------------------------------

SUCCESS: Integrated in HBase-1.3-IT #354 (See [https://builds.apache.org/job/HBase-1.3-IT/354/])
HBASE-14904 Mark Base[En|De]coder LimitedPrivate and fix binary compat (enis: rev edb8edfeb3564152dfacac0e5fe71ba295df821e)
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/CompressionContext.java
* hbase-common/src/main/java/org/apache/hadoop/hbase/codec/BaseDecoder.java
* hbase-common/src/main/java/org/apache/hadoop/hbase/codec/BaseEncoder.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALPrettyPrinter.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALCellCodec.java


> Mark Base[En|De]coder LimitedPrivate and fix binary compat issue
> ----------------------------------------------------------------
>
>                 Key: HBASE-14904
>                 URL: https://issues.apache.org/jira/browse/HBASE-14904
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Enis Soztutar
>            Assignee: Enis Soztutar
>             Fix For: 2.0.0, 1.2.0, 1.3.0, 1.1.3, 0.98.17, 1.0.4
>
>         Attachments: hbase-14904_v1.patch, hbase-14904_v2.patch
>
>
> PHOENIX-2477 revealed that the changes from HBASE-14501 breaks binary compatibility in Phoenix compiled with earlier versions of HBase and run agains later versions. 
> This is one of the areas that the boundary is not clear, but it won't hurt us to fix it. 
> The exception trace is: 
> {code}
> Exception in thread "main" java.lang.NoSuchFieldError: in
> 	at org.apache.hadoop.hbase.regionserver.wal.IndexedWALEditCodec$PhoenixBaseDecoder.<init>(IndexedWALEditCodec.java:106)
> 	at org.apache.hadoop.hbase.regionserver.wal.IndexedWALEditCodec$IndexKeyValueDecoder.<init>(IndexedWALEditCodec.java:121)
> 	at org.apache.hadoop.hbase.regionserver.wal.IndexedWALEditCodec.getDecoder(IndexedWALEditCodec.java:63)
> 	at org.apache.hadoop.hbase.regionserver.wal.ProtobufLogReader.initAfterCompression(ProtobufLogReader.java:292)
> 	at org.apache.hadoop.hbase.regionserver.wal.ReaderBase.init(ReaderBase.java:82)
> 	at org.apache.hadoop.hbase.regionserver.wal.ProtobufLogReader.init(ProtobufLogReader.java:148)
> 	at org.apache.hadoop.hbase.wal.WALFactory.createReader(WALFactory.java:316)
> 	at org.apache.hadoop.hbase.wal.WALFactory.createReader(WALFactory.java:281)
> 	at org.apache.hadoop.hbase.wal.WALFactory.createReader(WALFactory.java:269)
> 	at org.apache.hadoop.hbase.wal.WALFactory.createReader(WALFactory.java:418)
> 	at org.apache.hadoop.hbase.wal.WALPrettyPrinter.processFile(WALPrettyPrinter.java:247)
> 	at org.apache.hadoop.hbase.wal.WALPrettyPrinter.run(WALPrettyPrinter.java:422)
> 	at org.apache.hadoop.hbase.wal.WALPrettyPrinter.main(WALPrettyPrinter.java:357)
> {code}
> Although {{BaseDecoder.in}} is still there, it got changed to be a class rather than an interface. BaseDecoder is marked Private, thus the binary compat check is not run at all. Not sure whether it would have caught this. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)