Return-Path: 
 <issues-return-223077-apmail-hbase-issues-archive=hbase.apache.org@hbase.apache.org>
X-Original-To: apmail-hbase-issues-archive@www.apache.org
Delivered-To: apmail-hbase-issues-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 816BA183A0
	for <apmail-hbase-issues-archive@www.apache.org>;
 Mon,  7 Dec 2015 06:49:11 +0000 (UTC)
Received: (qmail 82121 invoked by uid 500); 7 Dec 2015 06:49:11 -0000
Delivered-To: apmail-hbase-issues-archive@hbase.apache.org
Received: (qmail 82072 invoked by uid 500); 7 Dec 2015 06:49:11 -0000
Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@hbase.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@hbase.apache.org>
List-Post: <mailto:issues@hbase.apache.org>
List-Id: <issues.hbase.apache.org>
Delivered-To: mailing list issues@hbase.apache.org
Received: (qmail 82054 invoked by uid 99); 7 Dec 2015 06:49:11 -0000
Received: from arcas.apache.org (HELO arcas) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 07 Dec 2015 06:49:11 +0000
Received: from arcas.apache.org (localhost [127.0.0.1])
	by arcas (Postfix) with ESMTP id 0EA362C1F57
	for <issues@hbase.apache.org>; Mon,  7 Dec 2015 06:49:11 +0000 (UTC)
Date: Mon, 7 Dec 2015 06:49:11 +0000 (UTC)
From: "Heng Chen (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12916902.1448874495000.286182.1449470951056@Atlassian.JIRA>
In-Reply-To: <JIRA.12916902.1448874495000@Atlassian.JIRA>
References: <JIRA.12916902.1448874495000@Atlassian.JIRA>
 <JIRA.12916902.1448874495810@arcas>
Subject: [jira] [Commented] (HBASE-14895) Seek only to the newly flushed
 file on scanner reset on flush
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/HBASE-14895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15044451#comment-15044451 ] 

Heng Chen commented on HBASE-14895:
-----------------------------------

{code}
-    List<KeyValueScanner> scanners = getScannersNoCompaction();
+    final boolean isCompaction = false;
+    boolean usePread = get || scanUsePread;
+    List<KeyValueScanner> scanners = store.getScanners(cacheBlocks, get, usePread, isCompaction,
+      matcher, scan.getStartRow(), scan.getStopRow(), this.readPt);
 
+    scanners = updatedStoreFiles(scanners, store.getComparator());
+    scanners = selectScannersFrom(scanners);
{code}
Should we move selectScannersFrom out from getScannersNoCompaction, and we could use getScannersNoCompaction directly here?

{code}
+  protected Set<StoreFileInfo> existingStoreFileInfos = new HashSet<StoreFileInfo>();
{code}
What it is used for?   It seems there is no use on it?

{code}
    * @param seekKey
    * @param isLazy true if using lazy seek
    * @param isParallelSeek true if using parallel seek
+   * @param updatedStoreFile 
    * @throws IOException
    */
{code}
I did not see param updatedStoreFile in seekScanners..... 





> Seek only to the newly flushed file on scanner reset on flush
> -------------------------------------------------------------
>
>                 Key: HBASE-14895
>                 URL: https://issues.apache.org/jira/browse/HBASE-14895
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>             Fix For: 2.0.0
>
>         Attachments: HBASE-14895.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)