Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 67CF81824A for ; Wed, 23 Dec 2015 03:18:47 +0000 (UTC) Received: (qmail 96414 invoked by uid 500); 23 Dec 2015 03:18:47 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 96355 invoked by uid 500); 23 Dec 2015 03:18:47 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 96330 invoked by uid 99); 23 Dec 2015 03:18:47 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 23 Dec 2015 03:18:47 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id B36572C1F62 for ; Wed, 23 Dec 2015 03:18:46 +0000 (UTC) Date: Wed, 23 Dec 2015 03:18:46 +0000 (UTC) From: "Hadoop QA (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-14867) SimpleRegionNormalizer needs to have better heuristics to trigger merge operation MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-14867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15069082#comment-15069082 ] Hadoop QA commented on HBASE-14867: ----------------------------------- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12779151/14867-v2.txt against master branch at commit 1af98f255132ef6716a1f6ba1d8d71a36ea38840. ATTACHMENT ID: 12779151 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0 2.7.1) {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 protoc{color}. The applied patch does not increase the total number of protoc compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 checkstyle{color}. The applied patch does not generate new checkstyle errors. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 lineLengths{color}. The patch does not introduce lines longer than 100 {color:green}+1 site{color}. The mvn post-site goal succeeds with this patch. {color:green}+1 core tests{color}. The patch passed unit tests in . {color:green}+1 zombies{color}. No zombie tests found running at the end of the build. Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/16983//testReport/ Release Findbugs (version 2.0.3) warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/16983//artifact/patchprocess/newFindbugsWarnings.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/16983//artifact/patchprocess/checkstyle-aggregate.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/16983//console This message is automatically generated. > SimpleRegionNormalizer needs to have better heuristics to trigger merge operation > --------------------------------------------------------------------------------- > > Key: HBASE-14867 > URL: https://issues.apache.org/jira/browse/HBASE-14867 > Project: HBase > Issue Type: Bug > Components: master > Affects Versions: 1.2.0 > Reporter: Romil Choksi > Assignee: Ted Yu > Attachments: 14867-v2.txt > > > SimpleRegionNormalizer needs to have better heuristics to trigger merge operation. SimpleRegionNormalizer is not able to trigger a merge action if the table's smallest region has neighboring regions that are larger than table's average region size, whereas there are other smaller regions whose combined size is less than the average region size. > For example, > - Consider a table with six region, say r1 to r6. > - Keep r1 as empty and create some data say, 100K rows of data for each of the regions r2, r3 and r4. Create smaller amount of data for regions r5 and r6, say about 27K rows of data. > - Run the normalizer. Verify the number the regions for that table and also check the master log to see if any merge action was triggered as a result of normalization. > In such scenario, it would be better to have a merge action triggered for those two smaller regions r5 and r6 even though either of them is not the smallest one -- This message was sent by Atlassian JIRA (v6.3.4#6332)