Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C891C18E1B for ; Thu, 3 Dec 2015 09:42:14 +0000 (UTC) Received: (qmail 52951 invoked by uid 500); 3 Dec 2015 09:42:11 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 52880 invoked by uid 500); 3 Dec 2015 09:42:11 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 52564 invoked by uid 99); 3 Dec 2015 09:42:11 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 03 Dec 2015 09:42:11 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 0F3AD2C1F6E for ; Thu, 3 Dec 2015 09:42:11 +0000 (UTC) Date: Thu, 3 Dec 2015 09:42:11 +0000 (UTC) From: "Jingcheng Du (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-14701) Fix flakey Failed tests: TestMobFlushSnapshotFromClient>TestFlushSnapshotFromClient.testSkipFlushTableSnapshot:199 null MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-14701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15037570#comment-15037570 ] Jingcheng Du commented on HBASE-14701: -------------------------------------- The cause of this issue is found. testSkipFlushTableSnapshot tries to check if the snapshot family (which must have store files) contains a provided family. It will be wrong when there are no store files under the snapshot family. In this case, if the memstore flushing is slower than the start of the admin.snapshot, the issue comes up. We need to make sure the flush is finished before snapshot starts. I will provide a patch to fix this. > Fix flakey Failed tests: TestMobFlushSnapshotFromClient>TestFlushSnapshotFromClient.testSkipFlushTableSnapshot:199 null > -------------------------------------------------------------------------------------------------------------------------- > > Key: HBASE-14701 > URL: https://issues.apache.org/jira/browse/HBASE-14701 > Project: HBase > Issue Type: Bug > Components: test > Reporter: stack > Assignee: Jingcheng Du > Attachments: disable.txt > > > This test has failed twice in last 24 hours. I removed it from master for now over in HBASE-14678. It fails a lot. See here: https://builds.apache.org/job/HBase-TRUNK/6962/testReport/history/ It recently got refactored to remove a bunch of duplicated code. Assigning to [~jingcheng.du@intel.com] to take a look if you have a chance please. Otherwise, unassign. Thanks. -- This message was sent by Atlassian JIRA (v6.3.4#6332)