hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Enis Soztutar (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-14989) Implementation of Mutation.getWriteToWAL() is backwards
Date Thu, 17 Dec 2015 19:31:46 GMT

    [ https://issues.apache.org/jira/browse/HBASE-14989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15062627#comment-15062627
] 

Enis Soztutar commented on HBASE-14989:
---------------------------------------

The tests failed, but the report or the console log does not contain any specific test failing.
I am not sure what is going on. I have checked that {{getWriteToWAL()}} is not used in the
HBase code base at all in branch-1. So test failures, if any, cannot be related. I think this
is safe to commit. 

> Implementation of Mutation.getWriteToWAL() is backwards
> -------------------------------------------------------
>
>                 Key: HBASE-14989
>                 URL: https://issues.apache.org/jira/browse/HBASE-14989
>             Project: HBase
>          Issue Type: Bug
>            Reporter: James Taylor
>             Fix For: 1.2.0, 1.3.0, 1.1.4, 0.98.17, 1.0.4
>
>         Attachments: HBASE-14989.1.branch-1.patch, hbase-14989-branch-1_v1.patch
>
>
> The implementation of the deprecated getWriteToWAL is backwards. It should return true
if this.durability == Durability.SYNC_WAL:
> {code}
> /**
>    * @deprecated Use {@link #getDurability()} instead.
>    * @return true if edits should be applied to WAL, false if not
>    */
>   @Deprecated
>   public boolean getWriteToWAL() {
>     return this.durability == Durability.SKIP_WAL;
>   }
> {code}
> For example, if mutation.durability is Durability.SYNC_WAL and the following code is
called {{clonedMutation.setWriteToWAL(mutation.getWriteToWAL())}}, it will disable writing
to the WAL for clonedMutation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message