hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-14985) TimeRange constructors should set allTime when appropriate
Date Wed, 16 Dec 2015 01:41:46 GMT

    [ https://issues.apache.org/jira/browse/HBASE-14985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15059310#comment-15059310
] 

Hadoop QA commented on HBASE-14985:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12777874/HBASE-14985.patch
  against master branch at commit 60d33ce34191533bb858852584bd9bddfeb16a23.
  ATTACHMENT ID: 12777874

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 3 new or modified
tests.

    {color:red}-1 patch{color}.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/16871//console

This message is automatically generated.

> TimeRange constructors should set allTime when appropriate
> ----------------------------------------------------------
>
>                 Key: HBASE-14985
>                 URL: https://issues.apache.org/jira/browse/HBASE-14985
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 1.1.2, 0.98.16.1
>            Reporter: Geoffrey Jacoby
>            Assignee: Geoffrey Jacoby
>            Priority: Minor
>         Attachments: HBASE-14985.patch
>
>
> The default TimeRange constructor creates a range from 0 to Long.MAX_VALUE and sets an
allTime flag to true. This flag allows some performance optimizations when comparing or using
TimeRanges.
> This flag is not set, however, if you call "new TimeRange(0L)" or "new TimeRange(0L,
Long.MAX_VALUE)", even though both of these create a logically equivalent TimeRange to "new
TimeRange()". Since TimeRanges are immutable and detecting this condition is trivial, we should
set the flag automatically in the explicit constructors when appropriate. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message