hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sean Busbey (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-14977) ChoreService.shutdown may result in ConcurrentModificationException
Date Fri, 18 Dec 2015 19:37:46 GMT

    [ https://issues.apache.org/jira/browse/HBASE-14977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15064595#comment-15064595
] 

Sean Busbey commented on HBASE-14977:
-------------------------------------

+1 for addendum.

review by [temp yetus build #24|https://builds.apache.org/view/PreCommit%20Builds/job/PreCommit-HBASE-Build-rewrite/24]:

-1 overall

| Vote |       Subsystem |  Runtime   | Comment
============================================================================
|   0  |         reexec  |  0m 0s     | Docker mode activated. 
|  +1  |      hbaseanti  |  0m 0s     | Patch does not have any anti-patterns. 
|  +1  |        @author  |  0m 0s     | The patch does not contain any @author 
|      |                 |            | tags.
|  -1  |     test4tests  |  0m 0s     | The patch doesn't appear to include any 
|      |                 |            | new or modified tests. Please justify
|      |                 |            | why no new tests are needed for this
|      |                 |            | patch. Also please list what manual
|      |                 |            | steps were performed to verify this
|      |                 |            | patch.
|  +1  |     mvninstall  |  5m 0s     | master passed 
|  +1  |        compile  |  0m 23s    | master passed with JDK v1.8.0_66 
|  +1  |        compile  |  0m 21s    | master passed with JDK v1.7.0_91 
|  +1  |     checkstyle  |  1m 26s    | master passed 
|  +1  |     mvneclipse  |  0m 20s    | master passed 
|  -1  |       findbugs  |  0m 56s    | hbase-common in master has 12 extant 
|      |                 |            | Findbugs warnings.
|  +1  |        javadoc  |  0m 28s    | master passed with JDK v1.8.0_66 
|  +1  |        javadoc  |  0m 21s    | master passed with JDK v1.7.0_91 
|  +1  |     mvninstall  |  0m 22s    | the patch passed 
|  +1  |        compile  |  0m 24s    | the patch passed with JDK v1.8.0_66 
|  +1  |          javac  |  0m 23s    | the patch passed 
|  +1  |        compile  |  0m 21s    | the patch passed with JDK v1.7.0_91 
|  +1  |          javac  |  0m 21s    | the patch passed 
|  +1  |     checkstyle  |  1m 21s    | the patch passed 
|  +1  |     mvneclipse  |  0m 12s    | the patch passed 
|  +1  |     whitespace  |  0m 0s     | Patch has no whitespace issues. 
|  +1  |    hadoopcheck  |  9m 17s    | Patch does not cause any errors with 
|      |                 |            | Hadoop 2.4.1 2.5.2 2.6.0.
|  +1  |       findbugs  |  1m 7s     | the patch passed 
|  +1  |        javadoc  |  0m 25s    | the patch passed with JDK v1.8.0_66 
|  +1  |        javadoc  |  0m 23s    | the patch passed with JDK v1.7.0_91 
|  +1  |           unit  |  2m 10s    | hbase-common in the patch passed with 
|      |                 |            | JDK v1.8.0_66.
|  +1  |           unit  |  2m 2s     | hbase-common in the patch passed with 
|      |                 |            | JDK v1.7.0_91.
|  +1  |     asflicense  |  0m 11s    | Patch does not generate ASF License 
|      |                 |            | warnings.
|      |                 |  42m 27s   | 


|| Subsystem || Report/Notes ||
============================================================================
| Docker | Client=1.9.1 Server=1.9.1 Image:yetus/hbase:date2015-12-18 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12778385/hbase-14977_addendum2.patch
|
| JIRA Issue | HBASE-14977 |
| Optional Tests |  asflicense  javac  javadoc  unit  findbugs  hadoopcheck  hbaseanti  checkstyle
 compile  |
| uname | Linux a724030391d3 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12
UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | master / ba04e03 |
| findbugs | v3.0.0 |
| findbugs | /testptch/patchprocess/branch-findbugs-hbase-common-warnings.html |
| JDK v1.7.0_91  Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build-rewrite/24/testReport/
|
| modules | C: hbase-common U: hbase-common |
| Max memory used | 176MB |
| Powered by | Apache Yetus 0.1.0   http://yetus.apache.org |
| Console output | https://builds.apache.org/job/PreCommit-HBASE-Build-rewrite/24/console
|


> ChoreService.shutdown may result in ConcurrentModificationException
> -------------------------------------------------------------------
>
>                 Key: HBASE-14977
>                 URL: https://issues.apache.org/jira/browse/HBASE-14977
>             Project: HBase
>          Issue Type: Bug
>          Components: util
>            Reporter: Vladimir Rodionov
>            Assignee: Vladimir Rodionov
>            Priority: Minor
>             Fix For: 2.0.0, 1.2.0, 1.3.0, 1.1.4
>
>         Attachments: HBASE-14977-add.patch, HBASE-14977-v1.patch, hbase-14977_addendum2.patch,
hbase-14977_addendum2.patch
>
>
> As seen in this test:
> https://builds.apache.org/job/HBase-1.3/jdk=latest1.8,label=Hadoop/425/artifact/hbase-server/target/surefire-reports/org.apache.hadoop.hbase.regionserver.compactions.TestFIFOCompactionPolicy-output.txt
> We need to make  shutdown method synchronized to avoid this issue. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message