hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sean Busbey (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-14964) Backport HBASE-14901 to brach-1 - There is duplicated code to create/manage encryption keys
Date Wed, 16 Dec 2015 21:35:46 GMT

    [ https://issues.apache.org/jira/browse/HBASE-14964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15060920#comment-15060920
] 

Sean Busbey commented on HBASE-14964:
-------------------------------------

running through things locally claims new checkstyle errors:

{code}
| Vote |       Subsystem |  Runtime   | Comment
============================================================================
|  +1  |      hbaseanti  |  0m 0s     | Patch does not have any anti-patterns. 
|  +1  |        @author  |  0m 0s     | The patch does not contain any @author 
|      |                 |            | tags.
|  +1  |     test4tests  |  0m 0s     | The patch appears to include 1 new or 
|      |                 |            | modified test files.
|  +1  |     mvninstall  |  4m 28s    | branch-1 passed 
|  +1  |     checkstyle  |  0m 36s    | branch-1 passed 
|  +1  |     mvneclipse  |  0m 39s    | branch-1 passed 
|   0  |       findbugs  |  1m 15s    | findbugs executables are not available. 
|  +1  |     mvninstall  |  1m 13s    | the patch passed 
|  -1  |     checkstyle  |  0m 13s    | Patch generated 2 new checkstyle issues 
|      |                 |            | in hbase-client (total was 1, now 2).
|  -1  |     checkstyle  |  0m 20s    | Patch generated 5 new checkstyle issues 
|      |                 |            | in hbase-server (total was 11, now 16).
|  +1  |     mvneclipse  |  0m 30s    | the patch passed 
|  +1  |     whitespace  |  0m 0s     | Patch has no whitespace issues. 
|  +1  |    hadoopcheck  |  5m 24s    | Patch does not cause any errors with 
|      |                 |            | Hadoop 2.4.1 2.5.2 2.6.0.
|  +1  |     asflicense  |  0m 19s    | Patch does not generate ASF License 
|      |                 |            | warnings.
|      |                 |  13m 44s   | 


|| Subsystem || Report/Notes ||
============================================================================
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12778014/HBASE-14964-branch-1.1.patch
|
| JIRA Issue | HBASE-14964 |
| Optional Tests |  asflicense  javac  javadoc  unit  findbugs  hadoopcheck  hbaseanti  checkstyle
 compile  |
| uname | Linux busbey.vpc.cloudera.com 3.10.0-229.11.1.el7.x86_64 #1 SMP Wed Jul 22 12:06:11
EDT 2015 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/busbey/yetus/yetus-0.1.0/lib/precommit/personality/hbase.sh |
| git revision | branch-1 / d2fb7e6 |
| checkstyle | /tmp/yetus-21889.12586/diff-checkstyle-hbase-client.txt |
| checkstyle | /tmp/yetus-21889.12586/diff-checkstyle-hbase-server.txt |
| modules | C: hbase-client hbase-server U: . |
| Max memory used | 135MB |
| Powered by | Apache Yetus 0.1.0   http://yetus.apache.org |

{code}

contents of {{/tmp/yetus-21889.12586/diff-checkstyle-hbase-client.txt}}

{code}
./hbase-client/src/main/java/org/apache/hadoop/hbase/security/EncryptionUtil.java:37:1: Duplicate
import to line 32 - org.apache.hadoop.conf.Configuration.
./hbase-client/src/main/java/org/apache/hadoop/hbase/security/EncryptionUtil.java:38:1: Duplicate
import to line 34 - org.apache.hadoop.hbase.HConstants.
{code}

contents of {{/tmp/yetus-21889.12586/diff-checkstyle-hbase-server.txt}}

{code}
./hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderV3.java:22:8: Unused
import - java.security.KeyException.
./hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderV3.java:40:8: Unused
import - org.apache.hadoop.hbase.security.User.
./hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java:24:8: Unused
import - java.security.Key.
./hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java:25:8: Unused
import - java.security.KeyException.
./hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java:67:8: Unused
import - org.apache.hadoop.hbase.io.crypto.Cipher.
{code}

it looks like the unit tests didn't fire, so I'm going to see if I can figure out why before
moving this out of patch available.

> Backport HBASE-14901 to brach-1 - There is duplicated code to create/manage encryption
keys
> -------------------------------------------------------------------------------------------
>
>                 Key: HBASE-14964
>                 URL: https://issues.apache.org/jira/browse/HBASE-14964
>             Project: HBase
>          Issue Type: Improvement
>          Components: encryption
>            Reporter: Nate Edel
>            Assignee: Nate Edel
>            Priority: Minor
>             Fix For: 1.2.0, 1.3.0
>
>         Attachments: HBASE-14964-branch-1.1.patch, HBASE-14964.patch
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> There is duplicated code from MobUtils.createEncryptionContext in HStore, and there is
a subset of that code in HFileReaderImpl.
> Refactored key selection 
> Moved both to EncryptionUtil.java
> Can't figure out how to write a unit test for this, but there's no new code just refactoring.
> A lot of the Mob stuff hasn't been backported, so this is a very small patch.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message