hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-14951) Make hbase.regionserver.maxlogs obsolete
Date Fri, 11 Dec 2015 05:12:11 GMT

    [ https://issues.apache.org/jira/browse/HBASE-14951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15052187#comment-15052187
] 

stack commented on HBASE-14951:
-------------------------------

This is an interesting change ( [~lhofhansl]... this is something you've been on about for
ever.)

The nice table does should go into the release notes.

Also, any chance of a longer exposition on why the formula (I grep -r memstoreSizeRatio but
find nothing... am I doing it wrong?)? Add this to release notes too because we need to hoist
this up into the documentation for 2.0.

Suggest marking this an incompatible change because it changes a fundamental behavior.

On this:

bq. ...... It was an agreement that we should calculate this number in a code but still need
to honor user's setting

... looking at patch, it seems to do as expected with nice warning....

Patch seems good. Its a fundamental change in our behavior so needs the fat release note.
 With that +1 (if the explanation makes sense -- smile)


> Make hbase.regionserver.maxlogs obsolete
> ----------------------------------------
>
>                 Key: HBASE-14951
>                 URL: https://issues.apache.org/jira/browse/HBASE-14951
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Vladimir Rodionov
>            Assignee: Vladimir Rodionov
>            Priority: Minor
>             Fix For: 2.0.0
>
>         Attachments: HBASE-14951-v1.patch, HBASE-14951-v2.patch
>
>
> There was a discussion in HBASE-14388 related to maximum number of log files. It was
an agreement that we should calculate this number in a code but still need to honor user's
setting. 
> Maximum number of log files now is calculated as following:
>  maxLogs = HEAP_SIZE * memstoreRatio * 2/ LogRollSize



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message