hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anoop Sam John (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-14938) Limit the number of znodes for ZK in bulk loaded hfile replication
Date Fri, 25 Dec 2015 01:55:49 GMT

    [ https://issues.apache.org/jira/browse/HBASE-14938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15071321#comment-15071321
] 

Anoop Sam John commented on HBASE-14938:
----------------------------------------

bq.int totalNoOfRequests = totalNoOfFiles / maxZnodesPerRequest;
Can we avoid having 2 loop code.. When totalNoOfFiles <maxZnodesPerRequest, I initially
thought u will get issue in 1st loop..  But then totalNoOfRequests  will be 0 and so we wont
go into 1st loop at all..   I would say readability wise this can be improved.
totalNoOfRequests  = 1 in that case and every case we have one loop doing the work?  Just
a suggestion..  See once pls.

How we have selected the def value to be 5000?
We will get these many files to be added in one call?

> Limit the number of znodes for ZK in bulk loaded hfile replication
> ------------------------------------------------------------------
>
>                 Key: HBASE-14938
>                 URL: https://issues.apache.org/jira/browse/HBASE-14938
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Ashish Singhi
>            Assignee: Ashish Singhi
>             Fix For: 2.0.0, 1.3.0
>
>         Attachments: HBASE-14938(1).patch, HBASE-14938-v1.patch, HBASE-14938.patch
>
>
> In ZK the maximum allowable size of the data array is 1 MB. Until we have fixed HBASE-10295
we need to handle this.
> Approach to this problem will be discussed in the comments section.
> Note: We have done internal testing with more than 3k nodes in ZK yet to be replicated.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message