hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-14938) Limit the number of znodes for ZK in bulk loaded hfile replication
Date Thu, 24 Dec 2015 11:05:49 GMT

    [ https://issues.apache.org/jira/browse/HBASE-14938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15070884#comment-15070884
] 

Ted Yu commented on HBASE-14938:
--------------------------------

{code}
458	    } else {
459	      List<ZKUtilOp> listOfOps = new ArrayList<ZKUtil.ZKUtilOp>(totalNoOfFiles);
460	      for (int i = 0; i < totalNoOfFiles; i++) {
{code}
The else branch should be covered by the new controlXX method(s), right (the remainder part)
?
Can you consolidate if and else branches so that readability is better ?

lgtm otherwise

> Limit the number of znodes for ZK in bulk loaded hfile replication
> ------------------------------------------------------------------
>
>                 Key: HBASE-14938
>                 URL: https://issues.apache.org/jira/browse/HBASE-14938
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Ashish Singhi
>            Assignee: Ashish Singhi
>             Fix For: 2.0.0, 1.3.0
>
>         Attachments: HBASE-14938(1).patch, HBASE-14938.patch
>
>
> In ZK the maximum allowable size of the data array is 1 MB. Until we have fixed HBASE-10295
we need to handle this.
> Approach to this problem will be discussed in the comments section.
> Note: We have done internal testing with more than 3k nodes in ZK yet to be replicated.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message