hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jianwei Cui (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-14936) CombinedBlockCache should overwrite CacheStats#rollMetricsPeriod()
Date Mon, 14 Dec 2015 11:26:46 GMT

    [ https://issues.apache.org/jira/browse/HBASE-14936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15055857#comment-15055857
] 

Jianwei Cui commented on HBASE-14936:
-------------------------------------

Thanks for your review [~chenheng]

> CombinedBlockCache should overwrite CacheStats#rollMetricsPeriod()
> ------------------------------------------------------------------
>
>                 Key: HBASE-14936
>                 URL: https://issues.apache.org/jira/browse/HBASE-14936
>             Project: HBase
>          Issue Type: Bug
>          Components: BlockCache
>    Affects Versions: 1.1.2
>            Reporter: Jianwei Cui
>            Assignee: Jianwei Cui
>             Fix For: 2.0.0, 1.2, 1.1, 1.3, 1.0
>
>         Attachments: HBASE-14936-branch-1.0-1.1.patch, HBASE-14936-branch-1.0-addendum.patch,
HBASE-14936-trunk-v1.patch, HBASE-14936-trunk-v2.patch, HBASE-14936-trunk.patch
>
>
> It seems CombinedBlockCache should overwrite CacheStats#rollMetricsPeriod() as
> {code}
> public void rollMetricsPeriod() {
>   lruCacheStats.rollMetricsPeriod();
>   bucketCacheStats.rollMetricsPeriod();
> }
> {code}
> otherwise, CombinedBlockCache.getHitRatioPastNPeriods() and CombinedBlockCache.getHitCachingRatioPastNPeriods()
will always return 0.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message