hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Appy (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-14916) Add checkstyle_report.py to other branches
Date Sat, 05 Dec 2015 06:12:10 GMT

    [ https://issues.apache.org/jira/browse/HBASE-14916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15042686#comment-15042686
] 

Appy commented on HBASE-14916:
------------------------------

So it's because we use {{patch -p1}}. Tools manual says this:
{noformat}
CAVEATS
Context  diffs  cannot  reliably  represent the creation or deletion of empty files, empty
directories, or special files such as
symbolic links. Nor can they represent changes to file metadata like ownership, permissions,
or whether one file is a hard link
to another. If  changes  like these  are  also required, separate instructions (e.g. a shell
script) to accomplish them should
accompany the patch.
{noformat}
Any way to get around it?

> Add checkstyle_report.py to other branches
> ------------------------------------------
>
>                 Key: HBASE-14916
>                 URL: https://issues.apache.org/jira/browse/HBASE-14916
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Appy
>            Assignee: Appy
>         Attachments: HBASE-14916-branch-1-v2.patch, HBASE-14916-branch-1-v3.patch, HBASE-14916-branch-1.patch
>
>
> Given test-patch.sh is always run from master, and that it now uses checkstyle_report.py,
we should pull back the script to other branches too.
> Otherwise we see error like: /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/jenkins.build/dev-support/test-patch.sh:
line 662: /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase/dev-support/checkstyle_report.py:
No such file or directory
> [reference|https://builds.apache.org/job/PreCommit-HBASE-Build/16734//consoleFull]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message