hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-14902) Revert some of the stringency recently introduced by checkstyle tightening
Date Wed, 02 Dec 2015 01:28:11 GMT

    [ https://issues.apache.org/jira/browse/HBASE-14902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15035071#comment-15035071

stack commented on HBASE-14902:

Let me add the single line allowance.

Thanks for quoting the Ref guide on empty lines. Agree. Let me make sure javadoc does not
complain if @throws not present.

On first item, when it says this: JavadocTagContinuationIndentation	Line continuation have
incorrect indentation level, expected level should be 4..... it wants me to put four spaces
after the '*' when I add a second line on javadoc? It seems so arbitrary. Why not two or none?
Most of the code seems to have none.. just continue on the line below? Shouldn't this be the

> Revert some of the stringency recently introduced by checkstyle tightening
> --------------------------------------------------------------------------
>                 Key: HBASE-14902
>                 URL: https://issues.apache.org/jira/browse/HBASE-14902
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: stack
>             Fix For: 2.0.0
> I think we should undo some of the plugins that were recently added to checkstyle. They
are too much.
> JavadocTagContinuationIndentationCheck is about adding indent if javadoc is two lines
or more (javadoc tool doesn't care)
> NonEmptyAtclauseDescriptionCheck would have us add javadoc on each exception: e.g. @throws
IOException needs to have text added.
> NeedBracesCheck has us undoing cases where an if fits all on one line (don't want to
start style wars but if short and fits on one line, I think its more readable... but I could
relent on this one.... ).
> The first two at least should go.
> You ok w/ that [~appy]

This message was sent by Atlassian JIRA

View raw message