hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-14891) Add log for uncaught exception in RegionServerMetricsWrapperRunnable
Date Tue, 01 Dec 2015 14:23:11 GMT

    [ https://issues.apache.org/jira/browse/HBASE-14891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15033742#comment-15033742

Hudson commented on HBASE-14891:

FAILURE: Integrated in HBase-1.3 #406 (See [https://builds.apache.org/job/HBase-1.3/406/])
HBASE-14891 Add log for uncaught exception in (chenheng: rev 2d7db89590a768762e037b6d920a223a5d923300)
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerWrapperImpl.java

> Add log for uncaught exception in RegionServerMetricsWrapperRunnable
> --------------------------------------------------------------------
>                 Key: HBASE-14891
>                 URL: https://issues.apache.org/jira/browse/HBASE-14891
>             Project: HBase
>          Issue Type: Improvement
>          Components: metrics
>            Reporter: Yu Li
>            Assignee: Yu Li
>            Priority: Minor
>             Fix For: 2.0.0, 1.3.0, 1.2.1
>         Attachments: HBASE-14891.branch-1.2.patch, HBASE-14891.branch-1.patch, HBASE-14891.patch,
HBASE-14891.v2.patch, HBASE-14891.v2.patch
> We are using ScheduledExecutorService#scheduleWithFixedDelay to periodically reporting
metrics. From javadoc of this method
> {quote}
> If any execution of the task encounters an exception, subsequent executions are suppressed.
> {quote}
> We could see if any uncaught exception like NPE thrown in the task thread, there won't
be any error thrown but the task would be silently terminated.
> In our real case we were making some modification to the metrics and causing NPE carelessly,
then we found metrics disappeared but cannot get a clue from RS log.
> Suggest to catch Throwable in MetricsRegionServerWrapperImpl$RegionServerMetricsWrapperRunnable,
add some log there and suppress the exception to give it another try at next scheduled run.

This message was sent by Atlassian JIRA

View raw message