hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "huaxiang sun (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-14730) region server needs to log warnings when there are attributes configured for cells with hfile v2
Date Wed, 16 Dec 2015 21:51:46 GMT

    [ https://issues.apache.org/jira/browse/HBASE-14730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15060956#comment-15060956
] 

huaxiang sun commented on HBASE-14730:
--------------------------------------

[~anoop.hbase] With help from [~mbertozzi], we found the flag you mentioned. I uploaded the
latest patch. Also found that in DefaultMemStore.java, it can be optimized for tagsPresent,
will create another jira for the optimization. Thanks.

  private boolean addToCellSet(Cell e) {
    boolean b = this.cellSet.add(e);
    // In no tags case this NoTagsKeyValue.getTagsLength() is a cheap call.
    // When we use ACL CP or Visibility CP which deals with Tags during
    // mutation, the TagRewriteCell.getTagsLength() is a cheaper call. We do not
    // parse the byte[] to identify the tags length.
-    if(e.getTagsLength() > 0) {
+    if(!tagsPresent && (e.getTagsLength() > 0)) {
      tagsPresent = true;
    }
    setOldestEditTimeToNow();
    return b;
  }

> region server needs to log warnings when there are attributes configured for cells with
hfile v2
> ------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-14730
>                 URL: https://issues.apache.org/jira/browse/HBASE-14730
>             Project: HBase
>          Issue Type: Improvement
>          Components: regionserver
>    Affects Versions: 1.0.0, 1.1.0, 1.2.0
>            Reporter: huaxiang sun
>            Assignee: huaxiang sun
>         Attachments: HBASE-14730-v001-1.2.0.patch, HBASE-14730-v001.patch, HBASE-14730-v002-1.2.0.patch
>
>
> User can configure cell attributes with hfile.format.version 2. When cells are flushed
from memStore to Hfile, attributes are not saved. Warnings need to be logged.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message