hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yu Li (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HBASE-14306) Refine RegionGroupingProvider: fix issues and make it more scalable
Date Tue, 22 Dec 2015 08:51:46 GMT

     [ https://issues.apache.org/jira/browse/HBASE-14306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Yu Li updated HBASE-14306:
--------------------------
    Release Note: 
In HBASE-14306 we've changed default strategy of RegionGroupingProvider from "identify" to
"bounded", so it's required to explicitly set "hbase.wal.regiongrouping.strategy" to "identify"
if user still wants to use one WAL per region

Please also notice that in the new framework there will be one WAL per group, and the region-group
mapping is decided by RegionGroupingStrategy. Accordingly, we've removed BoundedRegionGroupingProvider
and added BoundedRegionGroupingStrategy as a replacement. If you already have a customized
class for hbase.wal.regiongrouping.strategy, please check the new logic and make updates if
necessary.

  was:In HBASE-14306 we've changed default strategy of RegionGroupingProvider from "identify"
to "bounded", so it's required to explicitly set "hbase.wal.regiongrouping.strategy" to "identify"
if user still wants to use one WAL per region


[~busbey], thanks for the clarification and please check the updated release note, let me
know if still anything to add.

> Refine RegionGroupingProvider: fix issues and make it more scalable
> -------------------------------------------------------------------
>
>                 Key: HBASE-14306
>                 URL: https://issues.apache.org/jira/browse/HBASE-14306
>             Project: HBase
>          Issue Type: Improvement
>          Components: wal
>    Affects Versions: 2.0.0, 1.1.2
>            Reporter: Yu Li
>            Assignee: Yu Li
>             Fix For: 2.0.0, 1.3.0
>
>         Attachments: HBASE-14306.branch-1.patch, HBASE-14306.patch, HBASE-14306_v2.patch,
HBASE-14306_v3.patch, HBASE-14306_v3.patch, HBASE-14306_v4.patch, HBASE-14306_v5.patch
>
>
> There're multiple issues in RegionGroupingProvider, including:
> * The provider cache in it is using byte array as the key of ConcurrentHashMap, which
is not right (the reason is [here|http://stackoverflow.com/questions/1058149/using-a-byte-array-as-hashmap-key-java])
> * It's using IdentityGroupingStrategy to get group and use it as key of the cache, which
means the cache will include an entry for each region. This is especially unnecessary when
using BoundedRegionGroupingProvider
> Besides fixing the above issues, I suggest to change BoundedRegionGroupingProvider from
a *provider* to a pluggable *strategy*, which will make the whole picture much more clear.
> For more details, please refer to the patch



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message