hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anoop Sam John (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-12593) Tags and Tag dictionary to work with BB
Date Tue, 22 Dec 2015 01:56:46 GMT

    [ https://issues.apache.org/jira/browse/HBASE-12593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15067427#comment-15067427
] 

Anoop Sam John commented on HBASE-12593:
----------------------------------------

Not really Stack.. Then that interface has to be some thing which represent N Tags.
We have getTagsByteBuffer() also in Cell.  We iterate over byte[] or BB to search for certain
tag type. That is fine.  But we do have API to convert this to List<Tag>.  Tag is a
class and which can be backed by byte[] only.  So when the Cell data is in DBB, if any code
path uses this API way, we will end up in copying.  
So my idea was to do the same way what Cell is doing. We have interface and impls of byte[]
backing and DBB backing.
Same way Tag will be an interface. As it is only in server side, it might be ok to add both
APIs of byte[] and BB in same interface and have a hasArray() check. The getter for array
can throw Exception if Tag is DBB backed. (This is to simplify things from Cell way where
we have 2 interface for byte[] and BB)

> Tags and Tag dictionary to work with BB
> ---------------------------------------
>
>                 Key: HBASE-12593
>                 URL: https://issues.apache.org/jira/browse/HBASE-12593
>             Project: HBase
>          Issue Type: Sub-task
>          Components: regionserver, Scanners
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: Anoop Sam John
>
> Adding the subtask so that we don't forget it. Came up while reviewing the items required
for this parent task.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message