hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Enis Soztutar (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-10390) expose checkAndPut/Delete custom comparators in HTable
Date Tue, 15 Dec 2015 00:16:47 GMT

    [ https://issues.apache.org/jira/browse/HBASE-10390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15057032#comment-15057032
] 

Enis Soztutar commented on HBASE-10390:
---------------------------------------

It is strange that some of the "Comparators" are not comparators, but actual {{Comparable}}s
taking the value to compare. Of course, this issue is not for cleaning that up. 

An alternate would be to introduce: 
{code}
  boolean checkAndPut(byte[] row, byte[] family, byte[] qualifier,
    ByteArrayComparable comparable, CompareFilter.CompareOp compareOp, Put put) throws IOException;
{code}
Notice the lack of explicit value, which is carried over with the Comparator. I am not sure
this or the one in the patch is cleaner. I am fine with both. 

> expose checkAndPut/Delete custom comparators in HTable
> ------------------------------------------------------
>
>                 Key: HBASE-10390
>                 URL: https://issues.apache.org/jira/browse/HBASE-10390
>             Project: HBase
>          Issue Type: Improvement
>          Components: Client
>            Reporter: Sergey Shelukhin
>            Assignee: Vladimir Rodionov
>             Fix For: 2.0.0
>
>         Attachments: HBASE-10390-v1.patch, HBASE-10390-v2.patch, HBASE-10390-v3.patch
>
>
> checkAndPut/Delete appear to support custom comparators. However, thru HTable, there's
no way to pass one, it always creates BinaryComparator from value. It would be good to expose
the custom ones in the API.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message