Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 516C818C0F for ; Thu, 19 Nov 2015 07:29:16 +0000 (UTC) Received: (qmail 92496 invoked by uid 500); 19 Nov 2015 07:29:11 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 92443 invoked by uid 500); 19 Nov 2015 07:29:11 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 92421 invoked by uid 99); 19 Nov 2015 07:29:11 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 19 Nov 2015 07:29:11 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 048662C1F51 for ; Thu, 19 Nov 2015 07:29:11 +0000 (UTC) Date: Thu, 19 Nov 2015 07:29:11 +0000 (UTC) From: "Appy (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-14829) Add more checkstyles MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-14829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15013062#comment-15013062 ] Appy commented on HBASE-14829: ------------------------------ Yeah, I think we should do it. Having right checkstyles will prevent us from going in the wrong direction (bad code), and overtime this number will reduce. I believe we don't have to do anything else than just submitting the patch. Is that right. > Add more checkstyles > -------------------- > > Key: HBASE-14829 > URL: https://issues.apache.org/jira/browse/HBASE-14829 > Project: HBase > Issue Type: Improvement > Reporter: Appy > Assignee: Appy > Attachments: HBASE-14829-master-v2.patch, HBASE-14829-master-v2.patch, HBASE-14829-master.patch > > > This jira will add following checkstyles: > [ImportOrder|http://checkstyle.sourceforge.net/config_imports.html#ImportOrder] : keep imports in sorted order > [LeftCurly|http://checkstyle.sourceforge.net/config_blocks.html#LeftCurly] : Placement of left curly brace. Does 'eol' sounds right setting? > [NeedBraces|http://checkstyle.sourceforge.net/config_blocks.html#NeedBraces] : braces around code blocks > [JavadocTagContinuationIndentation|http://checkstyle.sourceforge.net/config_javadoc.html#JavadocTagContinuationIndentation] : Avoid weird indentations in javadocs > [NonEmptyAtclauseDescription|http://checkstyle.sourceforge.net/config_javadoc.html#NonEmptyAtclauseDescription] : We have sooooo many empty javadoc @ clauses. This'll take care of it. > > [Indentation|http://checkstyle.sourceforge.net/config_misc.html#Indentation] : Bad indentation hurts code readability. We have indentation guidelines, should be fine enforcing them. -- This message was sent by Atlassian JIRA (v6.3.4#6332)