Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Fri, 13 Nov 2015 03:18:11 +0000 (UTC)
From: "Appy (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12912685.1447377725000.58273.1447384691059@Atlassian.JIRA>
In-Reply-To: <JIRA.12912685.1447377725000@Atlassian.JIRA>
References: <JIRA.12912685.1447377725000@Atlassian.JIRA>
 <JIRA.12912685.1447377725561@arcas>
Subject: [jira] [Commented] (HBASE-14804) HBase shell's create table command
 ignores 'NORMALIZATION_ENABLED' attribute
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-14804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15003479#comment-15003479 ] 

Appy commented on HBASE-14804:
------------------------------

Just spent some redundant time on this because I wasn't aware that you were working on it in background too. But that's cool. Just make sure to assign issues to yourself if you planning to work on them. :)

As for the patch, lgtm.
Couple of suggestions to consider:
- This bug resulted from code duplication. Consider refactoring out common code into separate function to prevent the same in future. (You'll uncover another bug in the process)
- If you absolutely want to run the unit tests, you can create temporary [TestShell|https://github.com/apache/hbase/blob/dff86542d558394cc87ede256bd5432d071ed73f/hbase-shell/src/test/java/org/apache/hadoop/hbase/client/TestShell.java] in your repo.


> HBase shell's create table command ignores 'NORMALIZATION_ENABLED' attribute
> ----------------------------------------------------------------------------
>
>                 Key: HBASE-14804
>                 URL: https://issues.apache.org/jira/browse/HBASE-14804
>             Project: HBase
>          Issue Type: Bug
>          Components: shell
>    Affects Versions: 1.2.0, 1.1.2
>            Reporter: Romil Choksi
>            Assignee: Jean-Marc Spaggiari
>            Priority: Minor
>              Labels: beginner
>         Attachments: HBASE-14804.v0-trunk.patch
>
>
> I am trying to create a new table and set the NORMALIZATION_ENABLED as true, but seems like the argument NORMALIZATION_ENABLED is being ignored. And the attribute NORMALIZATION_ENABLED is not displayed on doing a desc command on that table
> {code}
> hbase(main):020:0> create 'test-table-4', 'cf', {NORMALIZATION_ENABLED => 'true'}
> An argument ignored (unknown or overridden): NORMALIZATION_ENABLED
> 0 row(s) in 4.2670 seconds
> => Hbase::Table - test-table-4
> hbase(main):021:0> desc 'test-table-4'
> Table test-table-4 is ENABLED                                                                                                                                                                               
> test-table-4                                                                                                                                                                                                
> COLUMN FAMILIES DESCRIPTION                                                                                                                                                                                 
> {NAME => 'cf', BLOOMFILTER => 'ROW', VERSIONS => '1', IN_MEMORY => 'false', KEEP_DELETED_CELLS => 'FALSE', DATA_BLOCK_ENCODING => 'NONE', TTL => 'FOREVER', COMPRESSION => 'NONE', MIN_VERSIONS => '0', BLOC
> KCACHE => 'true', BLOCKSIZE => '65536', REPLICATION_SCOPE => '0'}                                                                                                                                           
> 1 row(s) in 0.0430 seconds
> {code}
> However, on doing an alter command on that table we can set the NORMALIZATION_ENABLED attribute for that table
> {code}
> hbase(main):022:0> alter 'test-table-4', {NORMALIZATION_ENABLED => 'true'}
> Unknown argument ignored: NORMALIZATION_ENABLED
> Updating all regions with the new schema...
> 1/1 regions updated.
> Done.
> 0 row(s) in 2.3640 seconds
> hbase(main):023:0> desc 'test-table-4'
> Table test-table-4 is ENABLED                                                                                                                                                                               
> test-table-4, {TABLE_ATTRIBUTES => {NORMALIZATION_ENABLED => 'true'}                                                                                                                                        
> COLUMN FAMILIES DESCRIPTION                                                                                                                                                                                 
> {NAME => 'cf', BLOOMFILTER => 'ROW', VERSIONS => '1', IN_MEMORY => 'false', KEEP_DELETED_CELLS => 'FALSE', DATA_BLOCK_ENCODING => 'NONE', TTL => 'FOREVER', COMPRESSION => 'NONE', MIN_VERSIONS => '0', BLOC
> KCACHE => 'true', BLOCKSIZE => '65536', REPLICATION_SCOPE => '0'}                                                                                                                                           
> 1 row(s) in 0.0190 seconds
> {code}
> I think it would be better to have a single step process to enable normalization while creating the table itself, rather than a two step process to alter the table later on to enable normalization


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)