Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A0C9D18B28 for ; Sat, 7 Nov 2015 04:40:11 +0000 (UTC) Received: (qmail 8265 invoked by uid 500); 7 Nov 2015 04:40:11 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 7960 invoked by uid 500); 7 Nov 2015 04:40:11 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 7913 invoked by uid 99); 7 Nov 2015 04:40:11 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 07 Nov 2015 04:40:11 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 3745B2C1F73 for ; Sat, 7 Nov 2015 04:40:11 +0000 (UTC) Date: Sat, 7 Nov 2015 04:40:11 +0000 (UTC) From: "Hudson (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-14759) Avoid using Math.abs when selecting SyncRunner in FSHLog MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-14759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14995030#comment-14995030 ] Hudson commented on HBASE-14759: -------------------------------- SUCCESS: Integrated in HBase-1.2-IT #269 (See [https://builds.apache.org/job/HBase-1.2-IT/269/]) HBASE-14759 Avoid using Math.abs when selecting SyncRunner in FSHLog (zhangduo: rev 457fa656bcc3904758889019fac8ecb191161e7d) * hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestFSHLog.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSHLog.java > Avoid using Math.abs when selecting SyncRunner in FSHLog > -------------------------------------------------------- > > Key: HBASE-14759 > URL: https://issues.apache.org/jira/browse/HBASE-14759 > Project: HBase > Issue Type: Bug > Components: wal > Affects Versions: 2.0.0, 1.0.2, 1.2.0, 1.1.2, 1.3.0 > Reporter: Duo Zhang > Assignee: Duo Zhang > Fix For: 2.0.0, 1.2.0, 1.3.0, 1.0.3, 1.1.3 > > Attachments: HBASE-14759.patch > > > {code:title=FSHLog.java} > int index = Math.abs(this.syncRunnerIndex++) % this.syncRunners.length; > try { > this.syncRunners[index].offer(sequence, this.syncFutures, this.syncFuturesCount); > } catch (Exception e) { > // Should NEVER get here. > requestLogRoll(); > this.exception = new DamagedWALException("Failed offering sync", e); > } > {code} > Math.abs will return Integer.MIN_VALUE if you pass Integer.MIN_VALUE in since the actual absolute value of Integer.MIN_VALUE is out of range. > I think {{this.syncRunnerIndex++}} will overflow eventually if we keep the regionserver running for enough time. -- This message was sent by Atlassian JIRA (v6.3.4#6332)