Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1F5F818B44 for ; Wed, 4 Nov 2015 07:59:29 +0000 (UTC) Received: (qmail 69025 invoked by uid 500); 4 Nov 2015 07:59:28 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 68943 invoked by uid 500); 4 Nov 2015 07:59:28 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 68591 invoked by uid 99); 4 Nov 2015 07:59:28 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 04 Nov 2015 07:59:28 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id F032F2C1F72 for ; Wed, 4 Nov 2015 07:59:27 +0000 (UTC) Date: Wed, 4 Nov 2015 07:59:27 +0000 (UTC) From: "Hudson (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-14696) Support setting allowPartialResults in mapreduce Mappers MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-14696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14989079#comment-14989079 ] Hudson commented on HBASE-14696: -------------------------------- SUCCESS: Integrated in HBase-1.1-JDK8 #1671 (See [https://builds.apache.org/job/HBase-1.1-JDK8/1671/]) HBASE-14696 Support setting allowPartialResults in mapreduce Mappers (apurtell: rev 2d3c57ae04285af156c5f19db2d17947b7f2e3d2) * hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/ClientProtos.java * hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java * hbase-protocol/src/main/protobuf/Client.proto > Support setting allowPartialResults in mapreduce Mappers > -------------------------------------------------------- > > Key: HBASE-14696 > URL: https://issues.apache.org/jira/browse/HBASE-14696 > Project: HBase > Issue Type: Improvement > Components: mapreduce > Affects Versions: 2.0.0, 1.1.0 > Reporter: Mindaugas Kairys > Assignee: Ted Yu > Fix For: 2.0.0, 1.2.0, 1.3.0, 1.1.3 > > Attachments: 14696-branch-1-v1.txt, 14696-branch-1-v2.txt, 14696-branch-1-v2.txt, 14696-v1.txt, 14696-v2.txt > > > It is currently impossible to get partial results in mapreduce mapper jobs. > When setting setAllowPartialResults(true) for scan jobs, they still fail with OOME on large rows. > The reason is that Scan field allowPartialResults is lost during job creation: > 1. User creates a Job and sets a scan object via TableMapReduceUtil.initTableMapperJob(table_name, scanObj,...) -> which puts a result of TableMapReduceUtil.convertScanToString(scanObj) to the job config. > 2. When the job starts - method TableInputFormat.setConfig retrieves a scan string from config and converts it to Scan object by calling TableMapReduceUtil.convertStringToScan - which results in a Scan object with a field allowPartialResults always set to false. > I have tried to experiment and modify a TableInputFormat method setConfig() by forcing all scans to allow partial results and after this all jobs succeeded with no more OOME and I also noticed that mappers began to get partial results (Result.isPartial()). > My use case is very simple - I just have large rows and expect a mapper to get them partially - to get same rowid several times with different key/value records. > This would allow me not to worry about implementing my own result partitioning solution, which i would encounter in case the big amount of result key values could be transparently returned for a single large row. > And from the other side - if a Scan object can return several records for the same rowid (partial results), perhaps the mapper should do the same. -- This message was sent by Atlassian JIRA (v6.3.4#6332)