Return-Path: 
 <issues-return-220125-apmail-hbase-issues-archive=hbase.apache.org@hbase.apache.org>
X-Original-To: apmail-hbase-issues-archive@www.apache.org
Delivered-To: apmail-hbase-issues-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id BE1EC18646
	for <apmail-hbase-issues-archive@www.apache.org>;
 Wed, 11 Nov 2015 19:03:11 +0000 (UTC)
Received: (qmail 10685 invoked by uid 500); 11 Nov 2015 19:03:11 -0000
Delivered-To: apmail-hbase-issues-archive@hbase.apache.org
Received: (qmail 10454 invoked by uid 500); 11 Nov 2015 19:03:11 -0000
Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@hbase.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@hbase.apache.org>
List-Post: <mailto:issues@hbase.apache.org>
List-Id: <issues.hbase.apache.org>
Delivered-To: mailing list issues@hbase.apache.org
Received: (qmail 10116 invoked by uid 99); 11 Nov 2015 19:03:11 -0000
Received: from arcas.apache.org (HELO arcas) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 11 Nov 2015 19:03:11 +0000
Received: from arcas.apache.org (localhost [127.0.0.1])
	by arcas (Postfix) with ESMTP id 3D0BF2C1F5C
	for <issues@hbase.apache.org>; Wed, 11 Nov 2015 19:03:11 +0000 (UTC)
Date: Wed, 11 Nov 2015 19:03:11 +0000 (UTC)
From: "Ted Yu (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12903188.1444261633000.42530.1447268591246@Atlassian.JIRA>
In-Reply-To: <JIRA.12903188.1444261633000@Atlassian.JIRA>
References: <JIRA.12903188.1444261633000@Atlassian.JIRA>
 <JIRA.12903188.1444261633077@arcas>
Subject: [jira] [Commented] (HBASE-14575) Reduce scope of compactions
 holding region lock
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15000902#comment-15000902 ] 

Ted Yu commented on HBASE-14575:
--------------------------------

For #4. swap in compacted files, HStore#compact() calls replaceStoreFiles() where store level write lock is obtained :
{code}
  void replaceStoreFiles(final Collection<StoreFile> compactedFiles,
      final Collection<StoreFile> result) throws IOException {
    this.lock.writeLock().lock();
{code}

> Reduce scope of compactions holding region lock
> -----------------------------------------------
>
>                 Key: HBASE-14575
>                 URL: https://issues.apache.org/jira/browse/HBASE-14575
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Compaction, regionserver
>            Reporter: Nick Dimiduk
>            Assignee: Nick Dimiduk
>         Attachments: 14575-v1.patch, 14575-v2.patch, 14575-v3.patch, 14575-v4.patch, 14575-v5.patch, 14575.v00.patch
>
>
> Per [~devaraj]'s idea on parent issue, let's see if we can reduce the scope of critical section under which compactions hold the region read lock.
> Here is summary from parent issue:
> Another idea is we can reduce the scope of when the read lock is held during compaction. In theory the compactor only needs a region read lock while deciding what files to compact and at the time of committing the compaction. We're protected from the case of region close events because compactions are checking (every 10k bytes written) if the store has been closed in order to abort in such a case.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)