Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 830D4187D4 for ; Mon, 30 Nov 2015 16:18:11 +0000 (UTC) Received: (qmail 16973 invoked by uid 500); 30 Nov 2015 16:18:11 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 16921 invoked by uid 500); 30 Nov 2015 16:18:11 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 16892 invoked by uid 99); 30 Nov 2015 16:18:11 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 30 Nov 2015 16:18:11 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 164FF2C1F6E for ; Mon, 30 Nov 2015 16:18:11 +0000 (UTC) Date: Mon, 30 Nov 2015 16:18:11 +0000 (UTC) From: "stack (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-14531) graceful_stop.sh "if [ "$local" ]" condition unexpected behaviour MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-14531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15032024#comment-15032024 ] stack commented on HBASE-14531: ------------------------------- ? bq. However, test suite for jdk 1.8 passed. That don't make it right. ... and what is this about? {code} - if [ "$local" == true ]; then + if [ "$local" ==@#^& true ]; then {code} 1.2 test failed again in TestRowCounter.testRowCounterTimeRange Its a bit flakey anyways. Let me resolve this for now. Please do not commit without clean patch build. > graceful_stop.sh "if [ "$local" ]" condition unexpected behaviour > ----------------------------------------------------------------- > > Key: HBASE-14531 > URL: https://issues.apache.org/jira/browse/HBASE-14531 > Project: HBase > Issue Type: Bug > Components: scripts > Affects Versions: 2.0.0, 0.98.14, 1.0.3, 1.1.3 > Reporter: Samir Ahmic > Assignee: Samir Ahmic > Fix For: 2.0.0, 1.2.0, 1.3.0, 1.1.3, 0.98.17 > > Attachments: HBASE-14531.patch, HBASE-14531v2.patch, HBASE-14531v3.patch > > > We are using this condition to evaluate if graceful_stop.sh runs start/stop commands on local server or remote servers. Issue is that this condition is always true and causing unexpected behavior of script. > I will attach patch changing this condition to > {code} > if [ "$local" = true ] > {code} > -- This message was sent by Atlassian JIRA (v6.3.4#6332)