Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5D8C6186C7 for ; Sun, 8 Nov 2015 20:51:11 +0000 (UTC) Received: (qmail 47972 invoked by uid 500); 8 Nov 2015 20:51:11 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 47920 invoked by uid 500); 8 Nov 2015 20:51:11 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 47909 invoked by uid 99); 8 Nov 2015 20:51:11 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 08 Nov 2015 20:51:11 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 0B6DD2C1F62 for ; Sun, 8 Nov 2015 20:51:11 +0000 (UTC) Date: Sun, 8 Nov 2015 20:51:11 +0000 (UTC) From: "Lars Hofhansl (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-14511) StoreFile.Writer Meta Plugin MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-14511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14995798#comment-14995798 ] Lars Hofhansl commented on HBASE-14511: --------------------------------------- This is mostly good to go, no? I like how you avoided the iterator creation in all the hot loops. > StoreFile.Writer Meta Plugin > ---------------------------- > > Key: HBASE-14511 > URL: https://issues.apache.org/jira/browse/HBASE-14511 > Project: HBase > Issue Type: New Feature > Reporter: Vladimir Rodionov > Assignee: Vladimir Rodionov > Attachments: HBASE-14511-v3.patch, HBASE-14511.v1.patch, HBASE-14511.v2.patch > > > During my work on a new compaction policies (HBASE-14468, HBASE-14477) I had to modify the existing code of a StoreFile.Writer to add additional meta-info required by these new policies. I think that it should be done by means of a new Plugin framework, because this seems to be a general capability/feature. > As a future enhancement this can become a part of a more general StoreFileWriter/Reader plugin architecture. But I need only Meta section of a store file. > This could be used, for example, to collect rowkeys distribution information during hfile creation. This info can be used later to find the optimal region split key or to create optimal set of sub-regions for M/R jobs or other jobs which can operate on a sub-region level. -- This message was sent by Atlassian JIRA (v6.3.4#6332)