Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6FAC0186C0 for ; Mon, 2 Nov 2015 22:56:28 +0000 (UTC) Received: (qmail 15482 invoked by uid 500); 2 Nov 2015 22:56:27 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 15305 invoked by uid 500); 2 Nov 2015 22:56:27 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 15272 invoked by uid 99); 2 Nov 2015 22:56:27 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 02 Nov 2015 22:56:27 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id B7D782C1F5E for ; Mon, 2 Nov 2015 22:56:27 +0000 (UTC) Date: Mon, 2 Nov 2015 22:56:27 +0000 (UTC) From: "Hudson (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-13980) Distinguish blockedFlushCount vs unblockedFlushCount when tuning heap memory MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-13980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14986212#comment-14986212 ] Hudson commented on HBASE-13980: -------------------------------- SUCCESS: Integrated in HBase-1.2 #339 (See [https://builds.apache.org/job/HBase-1.2/339/]) HBASE-13980 Distinguish blockedFlushCount vs unblockedFlushCount when (eclark: rev 28932d287e053fc3b4594a7329c7dd8f737d39ce) * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DefaultHeapMemoryTuner.java * hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHeapMemoryManager.java > Distinguish blockedFlushCount vs unblockedFlushCount when tuning heap memory > ---------------------------------------------------------------------------- > > Key: HBASE-13980 > URL: https://issues.apache.org/jira/browse/HBASE-13980 > Project: HBase > Issue Type: Improvement > Reporter: Ted Yu > Assignee: Abhilash > Priority: Minor > Fix For: 2.0.0, 1.2.0, 1.3.0 > > Attachments: HBASE-13980-v1.patch, HBASE-13980-v1.patch, HBASE-13980.patch, HBASE-13980.patch > > > Currently DefaultHeapMemoryTuner doesn't distinguish blockedFlushCount vs unblockedFlushCount. > In its tune() method: > {code} > long totalFlushCount = blockedFlushCount+unblockedFlushCount; > rollingStatsForCacheMisses.insertDataValue(cacheMissCount); > rollingStatsForFlushes.insertDataValue(totalFlushCount); > {code} > Occurrence of blocked flush indicates that upper limit for memstore is not sufficient. > We should either give blockedFlushCount more weight or, take tuning action based on blockedFlushCount directly. > See discussion from tail of HBASE-13876. -- This message was sent by Atlassian JIRA (v6.3.4#6332)