hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-14890) Fix javadoc checkstyle errors
Date Sun, 29 Nov 2015 11:49:10 GMT

    [ https://issues.apache.org/jira/browse/HBASE-14890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15030894#comment-15030894
] 

Hudson commented on HBASE-14890:
--------------------------------

FAILURE: Integrated in HBase-Trunk_matrix #511 (See [https://builds.apache.org/job/HBase-Trunk_matrix/511/])
HBASE-14890 Fix broken checkstyle tool. Some javadocs had parsing errors (stack: rev 3bac31b2a49bca153df3b47a198667828b61f36e)
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ScannerContext.java
* hbase-common/src/main/java/org/apache/hadoop/hbase/Tag.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/handler/OpenRegionHandler.java
* hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/RpcClientImpl.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALSplitter.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/client/Query.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/LoadIncrementalHFiles.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileInfo.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MobCompactionStoreScanner.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/master/SplitLogManager.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationQueueInfo.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/util/RegionMover.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALKey.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/constraint/Constraints.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/mob/mapreduce/SweepMapper.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MobStoreScanner.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/monitoring/TaskMonitor.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/util/FSRegionScanner.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityController.java


> Fix javadoc checkstyle errors
> -----------------------------
>
>                 Key: HBASE-14890
>                 URL: https://issues.apache.org/jira/browse/HBASE-14890
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Appy
>            Assignee: Appy
>             Fix For: 2.0.0
>
>         Attachments: HBASE-14890-master.patch
>
>
> There are two checkstyles for javadoc: NonEmptyAtclauseDescriptionCheck and JavadocTagContinuationIndentation.
> Both require parsing javadoc, but there are some javadocs in codebase which it is not
able to parse. Depending on which rule the tool choses to check first it can throw different
errors. Now if trunk checks for A first and patch checks for B first, there will be A errors
in trunkCheckstyle.xml and B errors in patchCheckstyle.xml. Since B errors are only in patch,
checkstyle_report.py reports them are new errors.
> Here are two builds proving the point: 
> https://builds.apache.org/job/PreCommit-HBASE-Build/16668//consoleFull
> https://builds.apache.org/job/PreCommit-HBASE-Build/16676/consoleFull
> Snippets:
> {noformat}
> Build 16668:
> hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java	NonEmptyAtclauseDescriptionCheck
0	1
> hbase-common/src/main/java/org/apache/hadoop/hbase/Tag.java	NonEmptyAtclauseDescriptionCheck
10	11
> hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/RpcClientImpl.java	NonEmptyAtclauseDescriptionCheck
2	3
> .....
> Build 16676:
> hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java	JavadocTagContinuationIndentationCheck
0	1
> hbase-common/src/main/java/org/apache/hadoop/hbase/Tag.java	JavadocTagContinuationIndentationCheck
0	1
> hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java	JavadocTagContinuationIndentationCheck
0	1
> ....
> {noformat}
> The easiest fix here is to fix these 25 or so javadocs.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message