hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-14890) Fix javadoc checkstyle errors
Date Sat, 28 Nov 2015 03:20:10 GMT

    [ https://issues.apache.org/jira/browse/HBASE-14890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15030358#comment-15030358
] 

Hadoop QA commented on HBASE-14890:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12774671/HBASE-14890-master.patch
  against master branch at commit b280a41ba661f205eb5de33bb8e03c33e2b005d6.
  ATTACHMENT ID: 12774671

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions
(2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0 2.7.1)

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the total number of
protoc compiler warnings.

    {color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 2 warning messages.

    {color:green}+1 checkstyle{color}. The applied patch does not generate new checkstyle
errors.

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

  {color:green}+1 site{color}.  The mvn post-site goal succeeds with this patch.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/16685//testReport/
Release Findbugs (version 2.0.3) 	warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/16685//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/16685//artifact/patchprocess/checkstyle-aggregate.html

  Javadoc warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/16685//artifact/patchprocess/patchJavadocWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/16685//console

This message is automatically generated.

> Fix javadoc checkstyle errors
> -----------------------------
>
>                 Key: HBASE-14890
>                 URL: https://issues.apache.org/jira/browse/HBASE-14890
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Appy
>            Assignee: Appy
>         Attachments: HBASE-14890-master.patch
>
>
> There are two checkstyles for javadoc: NonEmptyAtclauseDescriptionCheck and JavadocTagContinuationIndentation.
> Both require parsing javadoc, but there are some javadocs in codebase which it is not
able to parse. Depending on which rule the tool choses to check first it can throw different
errors. Now if trunk checks for A first and patch checks for B first, there will be A errors
in trunkCheckstyle.xml and B errors in patchCheckstyle.xml. Since B errors are only in patch,
checkstyle_report.py reports them are new errors.
> Here are two builds proving the point: 
> https://builds.apache.org/job/PreCommit-HBASE-Build/16668//consoleFull
> https://builds.apache.org/job/PreCommit-HBASE-Build/16676/consoleFull
> Snippets:
> {noformat}
> Build 16668:
> hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java	NonEmptyAtclauseDescriptionCheck
0	1
> hbase-common/src/main/java/org/apache/hadoop/hbase/Tag.java	NonEmptyAtclauseDescriptionCheck
10	11
> hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/RpcClientImpl.java	NonEmptyAtclauseDescriptionCheck
2	3
> .....
> Build 16676:
> hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java	JavadocTagContinuationIndentationCheck
0	1
> hbase-common/src/main/java/org/apache/hadoop/hbase/Tag.java	JavadocTagContinuationIndentationCheck
0	1
> hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java	JavadocTagContinuationIndentationCheck
0	1
> ....
> {noformat}
> The easiest fix here is to fix these 25 or so javadocs.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message