hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-14832) Ensure write paths work with ByteBufferedCells in case of compaction
Date Thu, 19 Nov 2015 16:48:11 GMT

    [ https://issues.apache.org/jira/browse/HBASE-14832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15013835#comment-15013835

stack commented on HBASE-14832:

The patch will work though we've not converted PrefixTree? PrefixTree will run really slow
if it is doing copies all the time which will be a big surprise. I'd doubt anyone is using
PrefixTree but PrefixTree is something that we would want to take on after all the Cellification
is done as a mainline option I'd say. Ditto for TagCompression. It will work after the patch
goes in, it'll just be slow because of all the copies? If so, then I'd say could do these
two conversions in a follow up patch.

bq. One doubt - in case of DBEs the cell that we may get during compaction will be the DBE
cell right? 

Can you explain this more or point to a place in the code that shows what you are seeing?

One other question. I was looking at CellUtil the last day and remembered ByteRange. Was ByteRange
an experiment that now should be purged from the code base? I see it used by PrefixTree. Is
that the only place that uses it? I see support in MemStore. Should we undo it? If deprecated,
should we tidy it up some (it is spread about the codebase currently).

Skimming patch, its small! Seems good. Will do closer review later.

> Ensure write paths work with ByteBufferedCells in case of compaction
> --------------------------------------------------------------------
>                 Key: HBASE-14832
>                 URL: https://issues.apache.org/jira/browse/HBASE-14832
>             Project: HBase
>          Issue Type: Sub-task
>          Components: regionserver, Scanners
>    Affects Versions: 2.0.0
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>            Priority: Minor
>             Fix For: 2.0.0
>         Attachments: HBASE-14832.patch
> Currently any cell coming out of offheap Bucketcache while compaction does a copy using
the getXXXArray() API since write path does not work with BBCells. This JIRA is aimed at changing
the write path to support BBCells so that this copy is avoided.

This message was sent by Atlassian JIRA

View raw message